Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReflectometryISISCreateTransmission creates hidden workspaces if run as a child algorithm #39041

Open
MialLewis opened this issue Mar 11, 2025 · 0 comments
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Reflectometry Issues and pull requests related to reflectometry

Comments

@MialLewis
Copy link
Contributor

MialLewis commented Mar 11, 2025

Describe the bug
If ran as a child algorithm without an lvalue, ReflectometryISISCreateTransmission creates a hidden workspace in the ADS.

For example, ensuring Show Invisible Workspaces is selected in workbench settings:
ReflectometryISISCreateTransmission(InputRuns='POLREF32130', StoreInADS=False)

Observe a hidden workspace created in the ADS.

I don't think this is the correct behaviour. Child algorithms are routinely those called from other algorithms not via the simpleapi. You'd expect to just be able to be concerned with the scope of the return value, not be concerned about hidden ADS workspaces.

Expected behavior
If the algorithm is run as a child algorithm, no workspaces to be stored in the ADS.

Screenshots

Platform/Version (please complete the following information):

  • OS: [e.g. Windows, RHEL 7, Ubuntu, macOS]
  • OS Version:
  • Mantid Version [e.g. 6.0.0]

Additional context

@MialLewis MialLewis added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Reflectometry Issues and pull requests related to reflectometry labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Reflectometry Issues and pull requests related to reflectometry
Projects
Status: New
Development

No branches or pull requests

1 participant