withProps should take partial props instead of all props #7207
arvind0598
started this conversation in
Feature requests
Replies: 1 comment
-
Okay, I'll check that |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I've been playing around with creating generic (opt-in) components that the rest of the team can use. Using the full props instead of partial is an issue for situations like this:
This causes an error saying
... is missing the following properties from type 'DrawerProps': opened, onClose
. I don't think I should be providing those props here at all. For now, I'm able to work around it by just forcing all drawers to follow this via the createTheme, but I wanted to understand the rationale here so that I can use it for stuff like variants later.Beta Was this translation helpful? Give feedback.
All reactions