From 4c7a1ecd3696173c55c0ce1e65af972025b130ea Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 29 Sep 2025 08:28:37 +0000 Subject: [PATCH 1/4] Initial plan From 67e891e766b4928277bc49bec6f49515f3e71987 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 29 Sep 2025 08:38:08 +0000 Subject: [PATCH 2/4] Fix SonarCloud authentication issue and update scanner Co-authored-by: manusa <488391+manusa@users.noreply.github.com> --- .github/workflows/tests.yml | 3 + package-lock.json | 153 +++++++++++++++--------------------- package.json | 8 +- 3 files changed, 72 insertions(+), 92 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 5e388ee5..be9bb4cb 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -40,6 +40,9 @@ jobs: - name: Test run: NODE_OPTIONS=--experimental-vm-modules npm test - name: SonarCloud + # Only run SonarCloud scan if SONAR_TOKEN is available + # This prevents failures in fork PRs or when token is invalid + if: ${{ secrets.SONAR_TOKEN != '' }} run: | ./node_modules/.bin/sonar env: diff --git a/package-lock.json b/package-lock.json index dce7024d..9588ad1c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -38,7 +38,7 @@ "electronim": "bin.js" }, "devDependencies": { - "@sonar/scan": "4.3.0", + "@sonar/scan": "^4.3.2", "@testing-library/dom": "10.4.1", "@testing-library/user-event": "14.6.1", "chrome-tabs": "5.4.0", @@ -2723,45 +2723,47 @@ } }, "node_modules/@sonar/scan": { - "version": "4.3.0", - "resolved": "https://registry.npmjs.org/@sonar/scan/-/scan-4.3.0.tgz", - "integrity": "sha512-iJaK5BzVfXv/BGVaRYHP/xv6YzWNCDbFKORBxy8HSnyEvMSpt5kdd6Gh2T9EhZCmH+AwjvcKAPgHR+kI9qyheA==", + "version": "4.3.2", + "resolved": "https://registry.npmjs.org/@sonar/scan/-/scan-4.3.2.tgz", + "integrity": "sha512-dQiCZUPGstTWV6gJwZgbY25DPHN2l0qPv0dyd9/+0NY7Qqu/SKhwqslfBAqeQ1ZaDGabQT8c5NAyZPIcLdjFrw==", "dev": true, - "license": "LGPL-3.0-only", "dependencies": { - "adm-zip": "0.5.12", - "axios": "1.8.2", - "commander": "12.0.0", - "fs-extra": "11.2.0", + "adm-zip": "0.5.16", + "axios": "1.12.2", + "commander": "13.1.0", + "fs-extra": "11.3.2", "hpagent": "1.2.0", - "node-forge": "^1.3.1", - "properties-file": "3.5.4", - "proxy-from-env": "^1.1.0", - "semver": "7.6.0", + "node-forge": "1.3.1", + "properties-file": "3.6.1", + "proxy-from-env": "1.1.0", + "semver": "7.7.2", "slugify": "1.6.6", "tar-stream": "3.1.7" }, "bin": { "sonar": "bin/sonar-scanner.js", "sonar-scanner": "bin/sonar-scanner.js" + }, + "engines": { + "node": ">= 18" } }, "node_modules/@sonar/scan/node_modules/axios": { - "version": "1.8.2", - "resolved": "https://registry.npmjs.org/axios/-/axios-1.8.2.tgz", - "integrity": "sha512-ls4GYBm5aig9vWx8AWDSGLpnpDQRtWAfrjU+EuytuODrFBkqesN2RkOQCBzrA1RQNHw1SmRMSDDDSwzNAYQ6Rg==", + "version": "1.12.2", + "resolved": "https://registry.npmjs.org/axios/-/axios-1.12.2.tgz", + "integrity": "sha512-vMJzPewAlRyOgxV2dU0Cuz2O8zzzx9VYtbJOaBgXFeLc4IV/Eg50n4LowmehOOR61S8ZMpc2K5Sa7g6A4jfkUw==", "dev": true, "license": "MIT", "dependencies": { "follow-redirects": "^1.15.6", - "form-data": "^4.0.0", + "form-data": "^4.0.4", "proxy-from-env": "^1.1.0" } }, "node_modules/@sonar/scan/node_modules/commander": { - "version": "12.0.0", - "resolved": "https://registry.npmjs.org/commander/-/commander-12.0.0.tgz", - "integrity": "sha512-MwVNWlYjDTtOjX5PiD7o5pK0UrFU/OYgcJfjjK4RaHZETNtjJqrZa9Y9ds88+A+f+d5lv+561eZ+yCKoS3gbAA==", + "version": "13.1.0", + "resolved": "https://registry.npmjs.org/commander/-/commander-13.1.0.tgz", + "integrity": "sha512-/rFeCpNJQbhSZjGVwO9RFV3xPqbnERS8MmIQzCtD/zl6gpJuV/bMLuN92oG3F7d8oDEHHRrujSXNUr8fpjntKw==", "dev": true, "license": "MIT", "engines": { @@ -2769,9 +2771,9 @@ } }, "node_modules/@sonar/scan/node_modules/fs-extra": { - "version": "11.2.0", - "resolved": "https://registry.npmjs.org/fs-extra/-/fs-extra-11.2.0.tgz", - "integrity": "sha512-PmDi3uwK5nFuXh7XDTlVnS17xJS7vW36is2+w3xcv8SVxiB4NyATf4ctkVY5bkSjX0Y4nbvZCq1/EjtEyr9ktw==", + "version": "11.3.2", + "resolved": "https://registry.npmjs.org/fs-extra/-/fs-extra-11.3.2.tgz", + "integrity": "sha512-Xr9F6z6up6Ws+NjzMCZc6WXg2YFRlrLP9NQDO3VQrWrfiojdhS56TzueT88ze0uBdCTwEIhQ3ptnmKeWGFAe0A==", "dev": true, "license": "MIT", "dependencies": { @@ -2784,9 +2786,9 @@ } }, "node_modules/@sonar/scan/node_modules/jsonfile": { - "version": "6.1.0", - "resolved": "https://registry.npmjs.org/jsonfile/-/jsonfile-6.1.0.tgz", - "integrity": "sha512-5dgndWOriYSm5cnYaJNhalLNDKOqFwyDB/rr1E9ZsGciGvKPs8R2xYGCacuf3z6K1YKDz182fd+fY3cn3pMqXQ==", + "version": "6.2.0", + "resolved": "https://registry.npmjs.org/jsonfile/-/jsonfile-6.2.0.tgz", + "integrity": "sha512-FGuPw30AdOIUTRMC2OMRtQV+jkVj2cfPqSeWXv1NEAJ1qZ5zb1X6z1mFhbfOB/iy3ssJCD+3KuZ8r8C3uVFlAg==", "dev": true, "license": "MIT", "dependencies": { @@ -2796,22 +2798,6 @@ "graceful-fs": "^4.1.6" } }, - "node_modules/@sonar/scan/node_modules/semver": { - "version": "7.6.0", - "resolved": "https://registry.npmjs.org/semver/-/semver-7.6.0.tgz", - "integrity": "sha512-EnwXhrlwXMk9gKu5/flx5sv/an57AkRplG3hTK68W7FRDN+k+OWBj65M7719OkA82XLBxrcX0KSHj+X5COhOVg==", - "dev": true, - "license": "ISC", - "dependencies": { - "lru-cache": "^6.0.0" - }, - "bin": { - "semver": "bin/semver.js" - }, - "engines": { - "node": ">=10" - } - }, "node_modules/@sonar/scan/node_modules/tar-stream": { "version": "3.1.7", "resolved": "https://registry.npmjs.org/tar-stream/-/tar-stream-3.1.7.tgz", @@ -3785,13 +3771,13 @@ } }, "node_modules/adm-zip": { - "version": "0.5.12", - "resolved": "https://registry.npmjs.org/adm-zip/-/adm-zip-0.5.12.tgz", - "integrity": "sha512-6TVU49mK6KZb4qG6xWaaM4C7sA/sgUMLy/JYMOzkcp3BvVLpW0fXDFQiIzAuxFCt/2+xD7fNIiPFAoLZPhVNLQ==", + "version": "0.5.16", + "resolved": "https://registry.npmjs.org/adm-zip/-/adm-zip-0.5.16.tgz", + "integrity": "sha512-TGw5yVi4saajsSEgz25grObGHEUaDrniwvA2qwSC060KfqGPdglhvPMA2lPIoxs3PQIItj2iag35fONcQqgUaQ==", "dev": true, "license": "MIT", "engines": { - "node": ">=6.0" + "node": ">=12.0" } }, "node_modules/agent-base": { @@ -10092,9 +10078,9 @@ } }, "node_modules/properties-file": { - "version": "3.5.4", - "resolved": "https://registry.npmjs.org/properties-file/-/properties-file-3.5.4.tgz", - "integrity": "sha512-OGQPWZ4j9ENDKBl+wUHqNtzayGF5sLlVcmjcqEMUUHeCbUSggDndii+kjcBDPj3GQvqYB9sUEc4siX36wx4glw==", + "version": "3.6.1", + "resolved": "https://registry.npmjs.org/properties-file/-/properties-file-3.6.1.tgz", + "integrity": "sha512-9NUyJcxSqdWcJGRpPq6rT7exQbSQMPs0sK6KTvCJsLrTQRwq+hmt/wIB32ugNZmvEuSPyFO+y4nLK3vX34i5Wg==", "dev": true, "license": "MIT", "engines": { @@ -13806,45 +13792,45 @@ } }, "@sonar/scan": { - "version": "4.3.0", - "resolved": "https://registry.npmjs.org/@sonar/scan/-/scan-4.3.0.tgz", - "integrity": "sha512-iJaK5BzVfXv/BGVaRYHP/xv6YzWNCDbFKORBxy8HSnyEvMSpt5kdd6Gh2T9EhZCmH+AwjvcKAPgHR+kI9qyheA==", + "version": "4.3.2", + "resolved": "https://registry.npmjs.org/@sonar/scan/-/scan-4.3.2.tgz", + "integrity": "sha512-dQiCZUPGstTWV6gJwZgbY25DPHN2l0qPv0dyd9/+0NY7Qqu/SKhwqslfBAqeQ1ZaDGabQT8c5NAyZPIcLdjFrw==", "dev": true, "requires": { - "adm-zip": "0.5.12", - "axios": "1.8.2", - "commander": "12.0.0", - "fs-extra": "11.2.0", + "adm-zip": "0.5.16", + "axios": "1.12.2", + "commander": "13.1.0", + "fs-extra": "11.3.2", "hpagent": "1.2.0", - "node-forge": "^1.3.1", - "properties-file": "3.5.4", - "proxy-from-env": "^1.1.0", - "semver": "7.6.0", + "node-forge": "1.3.1", + "properties-file": "3.6.1", + "proxy-from-env": "1.1.0", + "semver": "7.7.2", "slugify": "1.6.6", "tar-stream": "3.1.7" }, "dependencies": { "axios": { - "version": "1.8.2", - "resolved": "https://registry.npmjs.org/axios/-/axios-1.8.2.tgz", - "integrity": "sha512-ls4GYBm5aig9vWx8AWDSGLpnpDQRtWAfrjU+EuytuODrFBkqesN2RkOQCBzrA1RQNHw1SmRMSDDDSwzNAYQ6Rg==", + "version": "1.12.2", + "resolved": "https://registry.npmjs.org/axios/-/axios-1.12.2.tgz", + "integrity": "sha512-vMJzPewAlRyOgxV2dU0Cuz2O8zzzx9VYtbJOaBgXFeLc4IV/Eg50n4LowmehOOR61S8ZMpc2K5Sa7g6A4jfkUw==", "dev": true, "requires": { "follow-redirects": "^1.15.6", - "form-data": "^4.0.0", + "form-data": "^4.0.4", "proxy-from-env": "^1.1.0" } }, "commander": { - "version": "12.0.0", - "resolved": "https://registry.npmjs.org/commander/-/commander-12.0.0.tgz", - "integrity": "sha512-MwVNWlYjDTtOjX5PiD7o5pK0UrFU/OYgcJfjjK4RaHZETNtjJqrZa9Y9ds88+A+f+d5lv+561eZ+yCKoS3gbAA==", + "version": "13.1.0", + "resolved": "https://registry.npmjs.org/commander/-/commander-13.1.0.tgz", + "integrity": "sha512-/rFeCpNJQbhSZjGVwO9RFV3xPqbnERS8MmIQzCtD/zl6gpJuV/bMLuN92oG3F7d8oDEHHRrujSXNUr8fpjntKw==", "dev": true }, "fs-extra": { - "version": "11.2.0", - "resolved": "https://registry.npmjs.org/fs-extra/-/fs-extra-11.2.0.tgz", - "integrity": "sha512-PmDi3uwK5nFuXh7XDTlVnS17xJS7vW36is2+w3xcv8SVxiB4NyATf4ctkVY5bkSjX0Y4nbvZCq1/EjtEyr9ktw==", + "version": "11.3.2", + "resolved": "https://registry.npmjs.org/fs-extra/-/fs-extra-11.3.2.tgz", + "integrity": "sha512-Xr9F6z6up6Ws+NjzMCZc6WXg2YFRlrLP9NQDO3VQrWrfiojdhS56TzueT88ze0uBdCTwEIhQ3ptnmKeWGFAe0A==", "dev": true, "requires": { "graceful-fs": "^4.2.0", @@ -13853,24 +13839,15 @@ } }, "jsonfile": { - "version": "6.1.0", - "resolved": "https://registry.npmjs.org/jsonfile/-/jsonfile-6.1.0.tgz", - "integrity": "sha512-5dgndWOriYSm5cnYaJNhalLNDKOqFwyDB/rr1E9ZsGciGvKPs8R2xYGCacuf3z6K1YKDz182fd+fY3cn3pMqXQ==", + "version": "6.2.0", + "resolved": "https://registry.npmjs.org/jsonfile/-/jsonfile-6.2.0.tgz", + "integrity": "sha512-FGuPw30AdOIUTRMC2OMRtQV+jkVj2cfPqSeWXv1NEAJ1qZ5zb1X6z1mFhbfOB/iy3ssJCD+3KuZ8r8C3uVFlAg==", "dev": true, "requires": { "graceful-fs": "^4.1.6", "universalify": "^2.0.0" } }, - "semver": { - "version": "7.6.0", - "resolved": "https://registry.npmjs.org/semver/-/semver-7.6.0.tgz", - "integrity": "sha512-EnwXhrlwXMk9gKu5/flx5sv/an57AkRplG3hTK68W7FRDN+k+OWBj65M7719OkA82XLBxrcX0KSHj+X5COhOVg==", - "dev": true, - "requires": { - "lru-cache": "^6.0.0" - } - }, "tar-stream": { "version": "3.1.7", "resolved": "https://registry.npmjs.org/tar-stream/-/tar-stream-3.1.7.tgz", @@ -14597,9 +14574,9 @@ "requires": {} }, "adm-zip": { - "version": "0.5.12", - "resolved": "https://registry.npmjs.org/adm-zip/-/adm-zip-0.5.12.tgz", - "integrity": "sha512-6TVU49mK6KZb4qG6xWaaM4C7sA/sgUMLy/JYMOzkcp3BvVLpW0fXDFQiIzAuxFCt/2+xD7fNIiPFAoLZPhVNLQ==", + "version": "0.5.16", + "resolved": "https://registry.npmjs.org/adm-zip/-/adm-zip-0.5.16.tgz", + "integrity": "sha512-TGw5yVi4saajsSEgz25grObGHEUaDrniwvA2qwSC060KfqGPdglhvPMA2lPIoxs3PQIItj2iag35fONcQqgUaQ==", "dev": true }, "agent-base": { @@ -18970,9 +18947,9 @@ } }, "properties-file": { - "version": "3.5.4", - "resolved": "https://registry.npmjs.org/properties-file/-/properties-file-3.5.4.tgz", - "integrity": "sha512-OGQPWZ4j9ENDKBl+wUHqNtzayGF5sLlVcmjcqEMUUHeCbUSggDndii+kjcBDPj3GQvqYB9sUEc4siX36wx4glw==", + "version": "3.6.1", + "resolved": "https://registry.npmjs.org/properties-file/-/properties-file-3.6.1.tgz", + "integrity": "sha512-9NUyJcxSqdWcJGRpPq6rT7exQbSQMPs0sK6KTvCJsLrTQRwq+hmt/wIB32ugNZmvEuSPyFO+y4nLK3vX34i5Wg==", "dev": true }, "proxy-from-env": { diff --git a/package.json b/package.json index a4b8addc..a700cf63 100644 --- a/package.json +++ b/package.json @@ -124,14 +124,14 @@ "icon": "icon_1024x1024.png", "target": [ { - "target":"dmg", + "target": "dmg", "arch": [ "x64", "arm64" ] }, { - "target":"tar.gz", + "target": "tar.gz", "arch": [ "x64", "arm64" @@ -186,7 +186,7 @@ "verbose": true }, "devDependencies": { - "@sonar/scan": "4.3.0", + "@sonar/scan": "^4.3.2", "@testing-library/dom": "10.4.1", "@testing-library/user-event": "14.6.1", "chrome-tabs": "5.4.0", @@ -210,8 +210,8 @@ "dictionary-ca": "2.6.0", "dictionary-ca-valencia": "2.6.0", "dictionary-de": "2.0.4", - "dictionary-en-gb": "2.4.0", "dictionary-en": "3.2.0", + "dictionary-en-gb": "2.4.0", "dictionary-es": "3.2.0", "dictionary-eu": "3.2.0", "dictionary-fr": "2.8.0", From 3af8230585b319020d84ec74fe5aa4b7de886753 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 29 Sep 2025 08:40:48 +0000 Subject: [PATCH 3/4] Confirm axios 1.12.0 compatibility with all tests passing Co-authored-by: manusa <488391+manusa@users.noreply.github.com> --- package-lock.json | 14 +++++++------- package.json | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index 9588ad1c..c8133945 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9,7 +9,7 @@ "version": "0.0.0", "license": "Apache-2.0", "dependencies": { - "axios": "1.11.0", + "axios": "^1.12.0", "dictionary-ca": "2.6.0", "dictionary-ca-valencia": "2.6.0", "dictionary-de": "2.0.4", @@ -4131,9 +4131,9 @@ } }, "node_modules/axios": { - "version": "1.11.0", - "resolved": "https://registry.npmjs.org/axios/-/axios-1.11.0.tgz", - "integrity": "sha512-1Lx3WLFQWm3ooKDYZD1eXmoGO9fxYQjrycfHFC8P0sCfQVXyROp0p9PFWBehewBOdCwHc+f/b8I0fMto5eSfwA==", + "version": "1.12.0", + "resolved": "https://registry.npmjs.org/axios/-/axios-1.12.0.tgz", + "integrity": "sha512-oXTDccv8PcfjZmPGlWsPSwtOJCZ/b6W5jAMCNcfwJbCzDckwG0jrYJFaWH1yvivfCXjVzV/SPDEhMB3Q+DSurg==", "license": "MIT", "dependencies": { "follow-redirects": "^1.15.6", @@ -14831,9 +14831,9 @@ "dev": true }, "axios": { - "version": "1.11.0", - "resolved": "https://registry.npmjs.org/axios/-/axios-1.11.0.tgz", - "integrity": "sha512-1Lx3WLFQWm3ooKDYZD1eXmoGO9fxYQjrycfHFC8P0sCfQVXyROp0p9PFWBehewBOdCwHc+f/b8I0fMto5eSfwA==", + "version": "1.12.0", + "resolved": "https://registry.npmjs.org/axios/-/axios-1.12.0.tgz", + "integrity": "sha512-oXTDccv8PcfjZmPGlWsPSwtOJCZ/b6W5jAMCNcfwJbCzDckwG0jrYJFaWH1yvivfCXjVzV/SPDEhMB3Q+DSurg==", "requires": { "follow-redirects": "^1.15.6", "form-data": "^4.0.4", diff --git a/package.json b/package.json index a700cf63..d2106100 100644 --- a/package.json +++ b/package.json @@ -206,7 +206,7 @@ "webpack": "5.101.3" }, "dependencies": { - "axios": "1.11.0", + "axios": "^1.12.0", "dictionary-ca": "2.6.0", "dictionary-ca-valencia": "2.6.0", "dictionary-de": "2.0.4", From 68df9e6fa10b2db4910bb08ffe25c79e5c3cf6e2 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Mon, 29 Sep 2025 08:55:53 +0000 Subject: [PATCH 4/4] Pin dependency versions and remove conditional SonarCloud step Co-authored-by: manusa <488391+manusa@users.noreply.github.com> --- .github/workflows/tests.yml | 3 --- package-lock.json | 4 ++-- package.json | 4 ++-- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index be9bb4cb..5e388ee5 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -40,9 +40,6 @@ jobs: - name: Test run: NODE_OPTIONS=--experimental-vm-modules npm test - name: SonarCloud - # Only run SonarCloud scan if SONAR_TOKEN is available - # This prevents failures in fork PRs or when token is invalid - if: ${{ secrets.SONAR_TOKEN != '' }} run: | ./node_modules/.bin/sonar env: diff --git a/package-lock.json b/package-lock.json index c8133945..b8c207c7 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9,7 +9,7 @@ "version": "0.0.0", "license": "Apache-2.0", "dependencies": { - "axios": "^1.12.0", + "axios": "1.12.0", "dictionary-ca": "2.6.0", "dictionary-ca-valencia": "2.6.0", "dictionary-de": "2.0.4", @@ -38,7 +38,7 @@ "electronim": "bin.js" }, "devDependencies": { - "@sonar/scan": "^4.3.2", + "@sonar/scan": "4.3.2", "@testing-library/dom": "10.4.1", "@testing-library/user-event": "14.6.1", "chrome-tabs": "5.4.0", diff --git a/package.json b/package.json index d2106100..7ca02326 100644 --- a/package.json +++ b/package.json @@ -186,7 +186,7 @@ "verbose": true }, "devDependencies": { - "@sonar/scan": "^4.3.2", + "@sonar/scan": "4.3.2", "@testing-library/dom": "10.4.1", "@testing-library/user-event": "14.6.1", "chrome-tabs": "5.4.0", @@ -206,7 +206,7 @@ "webpack": "5.101.3" }, "dependencies": { - "axios": "^1.12.0", + "axios": "1.12.0", "dictionary-ca": "2.6.0", "dictionary-ca-valencia": "2.6.0", "dictionary-de": "2.0.4",