Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched concept_type and type Concept attributes #153

Open
rossbowen opened this issue Feb 10, 2025 · 1 comment
Open

Mismatched concept_type and type Concept attributes #153

rossbowen opened this issue Feb 10, 2025 · 1 comment

Comments

@rossbowen
Copy link
Contributor

Describe the bug

A small one - but the Concept class defines an attribute called concept_type but parse_taxonomy() sets type instead.

Happy to submit a PR but unsure of whether to converge on concept_type or type.

self.concept_type: str or None = None

py-xbrl/xbrl/taxonomy.py

Lines 676 to 677 in 16c555c

concept = Concept(el_id, schema_url, el_name)
concept.type = element.attrib['type'] if 'type' in element.attrib else False

@rossbowen
Copy link
Contributor Author

Additionally, concept.type defaults to False but possibly should default to None.

rossbowen added a commit to rossbowen/py-xbrl that referenced this issue Feb 11, 2025
manusimidt added a commit that referenced this issue Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant