Fix scaling while preserving proportions #647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues with preserving proportions when editing the dimensions with the SpinButtons. Closes maoschanz#637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with preserving proportions when editing the dimensions with the SpinButtons. The problem was that the ratio that was being used was based on what the SpinButtons were changed to, rather than what they were originally. This caused things such as only the width changing. I tried to account for all possible interactions with the scale tool, but there might still be bugs if I didn't find them all.
This could also potentially close the issue #609. That one has a very similar issue to #637, but it doesn't mention the SpinButtons specifically, so it could be something else.
Closes #637