[maps-android] remove INDOOR_SELECTOR_PLUGIN from default plugin list (#9145)

GitOrigin-RevId: d62ac96f20bc2821d143a6dd35803b90e1f7f4f8

Author: natiginfo

CHANGELOG.md

@@ -18,7 +18,7 @@ Mapbox welcomes participation and contributions from everyone.
 * Add `ModelLayer.modelAllowDensityReduction` property to disable density reduction in model layers.
 * Add Standard Style color and 3D configuration options: `colorBuildings`, `colorCommercial`, `colorEducation`, `colorIndustrial`, `colorLand`, `colorMedical`, `show3dBuildings`, `show3dFacades`, `show3dLandmarks`, and `show3dTrees`.
 * Introduce experimental `AttributionControl` composable function that exposes `AttributionState` programmatically, enabling developers to build custom Attribution UI outside of the map while maintaining compliance with [Mapbox ToS](https://www.mapbox.com/legal/tos) requirements.
-* Introduce experimental indoor floor selector plugin. The plugin is disabled by default and requires a style with indoor data and special access to indoor mapping features.
+* Introduce experimental indoor floor selector plugin. The plugin is not included in the default plugin list and must be explicitly added to `MapInitOptions.plugins`. It requires a style with indoor data and special access to indoor mapping features.
 * Add experimental `shadowDrawBeforeLayer` property to directional light to allow specifying the position in the layer stack for drawing shadows on the ground.
 * [tile_store] Add method to set tilestore path to be used by default.
 * Faster polygon triangulation for complex polygons.

app/src/androidTest/java/com/mapbox/maps/testapp/indoorselector/generated/IndoorSelectorAttributeParserDefaultValueTest.kt

@@ -66,7 +66,6 @@ data class MapInitOptions @JvmOverloads constructor(
       Plugin.Mapbox(Plugin.MAPBOX_LIFECYCLE_PLUGIN_ID),
       Plugin.Mapbox(Plugin.MAPBOX_MAP_OVERLAY_PLUGIN_ID),
       Plugin.Mapbox(Plugin.MAPBOX_VIEWPORT_PLUGIN_ID),
-      Plugin.Mapbox(Plugin.MAPBOX_INDOOR_SELECTOR_PLUGIN_ID),
     )
   }
 }

app/src/androidTest/java/com/mapbox/maps/testapp/indoorselector/generated/IndoorSelectorAttributeParserTest.kt

@@ -2,14 +2,33 @@
 
 ### Overview
 
-The Mapbox Maps Indoor Selector Plugin for Android is a public library for displaying an indoor floor selector on top of a MapView. By default, the plugin will show a floor selector on the top-right corner of the map when indoor map data is available. The selector displays available floors and allows users to navigate between them. The plugin automatically shows and hides based on whether indoor data is present in the current map view.
+The Mapbox Maps Indoor Selector Plugin for Android is a public library for displaying an indoor floor selector on top of a MapView. When enabled, the plugin will show a floor selector on the top-right corner of the map when indoor map data is available. The selector displays available floors and allows users to navigate between them. The plugin automatically shows and hides based on whether indoor data is present in the current map view.
 
 A full overview of classes and interfaces can be found in our [API documentation](https://docs.mapbox.com/android/beta/maps/guides/).
 
 ### Getting Started
 
 This README is intended for developers who are interested in [contributing](https://github.com/mapbox/mapbox-maps-android/blob/master/CONTRIBUTING.md) to the Mapbox Maps Indoor Selector Plugin for Android. Please visit [DEVELOPING.md](https://github.com/mapbox/mapbox-maps-android/blob/master/DEVELOPING.md) for general information and instructions on how to use the Mapbox Maps Plugin System. To add the indoor selector plugin to your project, you configure its dependency in your `build.gradle` files.
 
+### Enabling the Plugin
+
+⚠️ **Important**: The indoor selector plugin is **not included in the default plugin list**. You must explicitly add it when creating your MapView.
+
+⚠️ **Known Issue - Native Memory Leak**: The indoor selector plugin currently registers a callback with `IndoorManager` that cannot be unregistered during the plugin lifecycle (see `IndoorSelectorPluginImpl.kt:138-140`). This callback remains active for the lifetime of the map instance, potentially causing native memory leaks. While the callback has an early-return guard when the plugin is disabled, it still incurs a small performance overhead on every indoor state update. A Flow-based implementation is planned to address this issue in a future release.
+
+**Recommendation**: Only add this plugin to your application if you specifically need indoor mapping functionality and have access to indoor map data with a supported style.
+
+```kotlin
+// In your Activity or Fragment
+val mapView = MapView(
+  this,
+  MapInitOptions(
+    context = this,
+    plugins = MapInitOptions.defaultPluginList + Plugin.Mapbox(Plugin.MAPBOX_INDOOR_SELECTOR_PLUGIN_ID)
+  )
+)
+```
+
 ```groovy
 // In the root build.gradle file
 // The Mapbox access token needs to a scope set to DOWNLOADS:READ

app/src/main/res/layout/generated_test_indoorselector.xml

@@ -10,7 +10,6 @@ import com.mapbox.maps.IndoorManager
 import com.mapbox.maps.IndoorState
 import com.mapbox.maps.MapboxExperimental
 import com.mapbox.maps.plugin.delegates.MapDelegateProvider
-import com.mapbox.maps.plugin.indoorselector.generated.IndoorSelectorAttributeParser
 import com.mapbox.maps.plugin.indoorselector.generated.IndoorSelectorSettings
 import com.mapbox.maps.plugin.indoorselector.generated.IndoorSelectorSettingsBase
 import java.util.concurrent.CopyOnWriteArraySet
@@ -90,8 +89,6 @@ internal class IndoorSelectorPluginImpl(
    * @return View that will be added to the MapView
    */
   override fun bind(mapView: FrameLayout, attrs: AttributeSet?, pixelRatio: Float): View {
-    internalSettings =
-      IndoorSelectorAttributeParser.parseIndoorSelectorSettings(mapView.context, attrs, pixelRatio)
     return viewImplProvider(mapView.context).also {
       it.injectPresenter(this)
     }