Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qaseprite install step to packages.yml #4123

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dogboydog
Copy link
Contributor

@dogboydog dogboydog commented Dec 20, 2024

Fix #4109

Build and bundle qaseprite plugin with Tiled

  • Linux (AppImage)
  • Linux (Snap)
  • MacOS
  • Windows

Copy link
Member

@bjorn bjorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments. Overall, I think we can wait a bit with merging this until we have tried adding it for other platforms as well.

.github/workflows/packages.yml Outdated Show resolved Hide resolved
.github/workflows/packages.yml Show resolved Hide resolved
@bjorn
Copy link
Member

bjorn commented Dec 20, 2024

The macOS build failure is a recent breakage in the workflow, which I'm trying to address in #4124 now.

@dogboydog
Copy link
Contributor Author

dogboydog commented Dec 22, 2024

image
This build worked for me on macOS Sonoma (x86)
https://github.com/dogboydog/tiled/actions/runs/12450020727

@bjorn
Copy link
Member

bjorn commented Dec 22, 2024

Hmm, for both versions I get this on Sequoia 15.1:

image

Not sure yet what the issue is, I don't get any additional output when running from a terminal. My first guess would be some missing library, but I couldn't find any. I also tried removing the Contents/PlugIns/imageformats/libqaseprite.dylib file, but Tiled still wouldn't launch.

@dogboydog
Copy link
Contributor Author

I have this problem all the time on mac (including with the Tiled builds I tested). I have to do this:

xattr -r -d com.apple.quarantine Tiled.app

@bjorn
Copy link
Member

bjorn commented Dec 22, 2024

I have this problem all the time on mac (including with the Tiled builds I tested).

Ah, of course, since these builds are from the pull request, they're not signed and notarized. Boy, what a strangely misleading error message... Indeed, after doing that the builds work and the plugin loads!

@dogboydog
Copy link
Contributor Author

I agree the error message is not helpful at all, very aggressive how it tells you to send it to the trash lol... I get the same when I try to test my games on a mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: use aseprite file in tilesheet
2 participants