Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken mapbox URL support #25

Open
ianthetechie opened this issue Jan 12, 2023 · 2 comments
Open

Remove broken mapbox URL support #25

ianthetechie opened this issue Jan 12, 2023 · 2 comments

Comments

@ianthetechie
Copy link
Collaborator

It doesn't look like these are working correctly at the moment. I believe the underlying native lib has support for custom URL schemes (and MapTiler right now?), so this wrapper is probably at fault. We should figure out the best way to support these going forward.

@wipfli
Copy link

wipfli commented Jan 13, 2023

Thanks for opening this issue, @ianthetechie. Since MapLibre is vendor neutral, I think we should not maintain protocols of map service providers inside the MapLibre Organization. Instead, we should make it easy for service providers to hook their custom logic into our libraries. In MapLibre GL JS, we can achieve custom protocols with the addProtocol function.

In MapLibre GL Native, there is probably still the support for the maptiler protocol, but this is just a leftover from when MapTiler donated the repository to MapLibre. It will be removed in the future.

@ianthetechie
Copy link
Collaborator Author

ianthetechie commented Jan 14, 2023 via email

@ianthetechie ianthetechie changed the title Investigate Mapbox URLs not working Remove broken mapbox URL support Jan 14, 2023
@KiwiKilian KiwiKilian removed the bug label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants