-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for a new classification of mapping relations #3
Comments
Proposed skeleton of the mathematical mapping predicates:
skos:exactMatch should be 1:1, but there may be 1:1 matches that are not exact matches (or even in the skos hierarchy). E.g. cross-species exact/broad/narrow/related analog matches |
@cthoyt notes the fact that as it stands, |
@matentzn Could we look at concrete examples, please? There is probably already be a document with these; if so could you please share it? Thank you. |
There are no docs yet about this at all - what exactly would you like to see examples for? The cross species mappings are well described in the linked OMO issue, and the isomorphicMatch relationship should not actually be instantiated, so you can't really give a good example? |
Here are some examples of how I would (tentatively) use those relations, the way I understand them, for my primary use case of mappings between Uberon/CL and FBbt (of note, I do indeed find confusing that
I don’t have any example readily available of a narrow match. I don’t actually think there will ever be one in the case of FBbt-to-Uberon/CL mappings. I note that there is another way to interpret the
I don’t think this interpretation would be much useful. All mappings between Uberon/CL and any taxon-specific ontology such as FBbt would end up being broad matches, without any more possibility for nuance. |
I feel like these discussions are losing sight of the important aim of being able to generate OWL bridge files, e.g. between Uberon & FBbt; CL & FBbt. These have traditionally been interpreted as EquivalentTo X and in_taxon some Y. It's hard to see how we get from generic cross-species AP predicates to this, except by some form of hackery. One of the advantages of SSSOM is that we can use it to generate OWL. Would it be stretching the formalism too far to find a way to support compound predicates of EquivalentTo + Taxon ID that get translated to the desired OWL? |
I was hoping that once an agreement has (finally) been reached as to what predicate to use, we could then add support (probably in
I don’t know it would stretch the formalism. My concern with such an approach is that it would make it more difficult to re-use the mapping set for another use case than just generating the bridges, should anyone be wanting to do that. That being said, the use case we have right now is generating the bridges (I am not aware of anyone interested in using the FBbt/Uberon/CL mappings to do anything else), so I’d support any move going in that direction – if it reduces the usefulness and the re-usability of the SSSOM mapping set, that’s just too bad but I can live with it. |
Lets go ahead with this. @gouttegd whenever you get a chance, can you make a PR to add the relations? I would suggest to create a new file copied from https://github.com/mapping-commons/semantic-mapping-vocabulary/blob/main/semapv-terms.tsv, called |
This commit adds a handful of properties intended to represent mapping relations. Some of these properties are directly taken from the SKOS specification, but re-classified in a custom hierarchy. The others are new properties specifically intended to represent cross-species mappings. This is an implementation of the proposal in mapping-commons#3.
This has nothing to do with the PR, but I believe that species-specific to species-neutral use cases should resort to the skos standard mapping vocabulary (skos:broadMatch instead of semapv:crossSpeciesBroadMatch). |
You realise that “species-specific to species-neutral” is THE use case I have been requesting a specific relation for since the very beginning, right? It’s for the mappings between FBbt (Drosophila-specific) and Uberon/CL (species-neutral). I thought we agreed on that. I’ve stated since July last year (my comment above) that I would use the My PR (#14) explicitly uses “species-specific to species-neutral” cases as examples for the |
Let's at least decouple the debate of the PR on the best way to apply the relations. Both paths are justifiable. I would argue that a term that is truly taxon independent is a literal parent of their species specific counterparts, so there may not be a need to introduce special vocabulary for this. This is not the case for fly eye to human eye. Here we really need a special vocabulary. Let's keep this a bit open for now. Both paths are possible, and I am happy to hear your arguments over a beer in Padua. |
I don’t understand. One of the main arguments against the introduction of new relations for cross-species mappings was that the risk of “mapping predicate proliferation” – that is, creating a precedent that would trigger the creation of way too many mapping predicates. And now you’re seemingly willing to go ahead with the creation of new mapping predicates before we even agree on what those predicates should be used for? So we could create the predicate and later finally decide that, well no, in the end we won’t use those, let’s use the pre-existing SKOS ones instead?
First, this may be true only for “exact” matches (e.g. FBbt’s Drosophila “muscle cell” to CL’s taxon-neutral “muscle cell”). This is not applicable for not-so-clear-cut mappings (the ones for which I was planning to use Second, even if we decide that cross-species mappings should be limited to the exact cases (so, we do not try to represent “not-so-clear-cut” mappings), not using a specific relation for them would lead to the same issue than we currently have with
Fine. But then FYI, I am considering switching the generation of the FBbt-to-Uberon/CL bridges to a (hopefully temporary) in-house, ad-hoc system that will bypass SSSOM completely. I can’t stand the current system anymore and I’ve been waiting for months to replace it with a generic, SSSOM-based mechanism ideally directly built-in within the ODK – something that was dependent on having agreed-upon relations to represent cross-species mappings. Clearly there is no agreement on how to represent those, and I am not sure I want to wait until there is one.
I think I’ve presented my arguments many times already. If you’re not convinced yet, not sure what else I can do — apart maybe from getting you so drunk that you’d accept anything. :p |
Alright, this is now done. Thanks for your driving on this @gouttegd |
This is the initial draft for a better classification of semantic mapping relations. It is based on the skos classification of mapping relations, and extends it to allow for additional kinds of mapping relationships such as cross-species mappings and potentially other kinds of conflation relations (gene-reference, disease-phenotype protein, etc). It has been often noted that we are over-using skos:exactMatch massively for isomorphic concepts, and a new vocabulary of mapping relations, conservatively evolved (to avoid proliferation), will not only allow us to cater for these use cases, but also avoid watering down
exactMatch
further. In order to group all kinds of isomorphic match properties (definition below) we introduce a new mapping relationshipsemapv:isomorphicMatch
, which groups relationships likeskos:exactMatch
/semapv:crossSpeciesExactMatch
under one parent.semapv:isomorphicMatch
is not (at least not as part of the intended use case) here supposed to be used as a mapping predicate, just to group other mapping predicates.The text was updated successfully, but these errors were encountered: