Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm test fails on windows #1

Open
mspears-quotecenter opened this issue May 9, 2019 · 0 comments
Open

npm test fails on windows #1

mspears-quotecenter opened this issue May 9, 2019 · 0 comments

Comments

@mspears-quotecenter
Copy link

After cloning the project to run through the excercises, I noticed that the test script uses an environment variable. We run into this issue a lot here at work, due to devs using macs and windows boxes. This is easily fixed by adding cross-env to a project, and calling it before you set any envs in a script.

Since there wasn't a project specific CONTRIBUTING.md, I wasn't sure if I should open a pr here to make the quick fix. Let me know if I should, if it'd help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant