Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to properly migrate to pydantic v2 (current patch is not a long-term solution) #177

Closed
maread99 opened this issue Jul 3, 2023 · 1 comment
Closed

Need to properly migrate to pydantic v2 (current patch is not a long-term solution) #177

maread99 opened this issue Jul 3, 2023 · 1 comment
Labels
dependencies Pull requests that update a dependency file maintenance Keeping it all up to date

Comments

@maread99
Copy link
Owner

maread99 commented Jul 3, 2023

#176 added a short-term patch to support pydantic v2. This just detects (in a pretty precarious manner) if user has imported pydantic v2 and if so it imports v1 (which is accessible via v2) over the v2 version. This is not a long-term solution.

Need to migrate to pydantic v2
@maread99 maread99 added maintenance Keeping it all up to date dependencies Pull requests that update a dependency file labels Jul 3, 2023
@maread99 maread99 pinned this issue Jul 4, 2023
@maread99 maread99 mentioned this issue Sep 9, 2023
Merged
@maread99
Copy link
Owner Author

maread99 commented Sep 9, 2023 •
edited
Loading

Closed by #204 which drops pydantic in favor of using valimp for validation of public functions.

@maread99 maread99 unpinned this issue Sep 9, 2023
@maread99 maread99 closed this as completed Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file maintenance Keeping it all up to date
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maread99