Skip to content

Commit 7a81fc0

Browse files
fix: Remove deprecated ArrayBuffer::makeBuffer and fix Nitro specs (#118)
* replace deprecated makeBuffer with wrap * feat: update nitro-modules to v0.24.1 * chore: udpate nitro-codegen * chore: update nitro specs * Update Podfile.lock * chore: bump minimum react-native version to 0.75 * fix: swift issue in latest Xcode --------- Co-authored-by: Christoph Pader <[email protected]>
1 parent 6e53b3e commit 7a81fc0

21 files changed

+89
-19
lines changed

β€Žbun.lockbβ€Ž

-1.03 KB
Binary file not shown.

β€Žexample/ios/Podfileβ€Ž

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,11 @@ target 'NitroSQLiteExample' do
4444
installer.pods_project.build_configurations.each do |config|
4545
config.build_settings['DEAD_CODE_STRIPPING'] = 'YES'
4646
end
47+
48+
installer.pods_project.targets.each do |target|
49+
target.build_configurations.each do |config|
50+
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '16.6'
51+
end
52+
end
4753
end
4854
end

β€Žexample/ios/Podfile.lockβ€Ž

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ PODS:
77
- hermes-engine (0.76.1):
88
- hermes-engine/Pre-built (= 0.76.1)
99
- hermes-engine/Pre-built (0.76.1)
10-
- NitroModules (0.20.1):
10+
- NitroModules (0.24.1):
1111
- DoubleConversion
1212
- glog
1313
- hermes-engine
@@ -1887,7 +1887,7 @@ SPEC CHECKSUMS:
18871887
fmt: 10c6e61f4be25dc963c36bd73fc7b1705fe975be
18881888
glog: 08b301085f15bcbb6ff8632a8ebaf239aae04e6a
18891889
hermes-engine: 46f1ffbf0297f4298862068dd4c274d4ac17a1fd
1890-
NitroModules: ff8680342cb7008646d8160ff9b30ba74c681c11
1890+
NitroModules: 6a468c0eebd9aa957828528ee7754914605100a7
18911891
RCT-Folly: bf5c0376ffe4dd2cf438dcf86db385df9fdce648
18921892
RCTDeprecation: fde92935b3caa6cb65cbff9fbb7d3a9867ffb259
18931893
RCTRequired: 75c6cee42d21c1530a6f204ba32ff57335d19007
@@ -1945,11 +1945,11 @@ SPEC CHECKSUMS:
19451945
React-utils: 5362bd16a9563f9916e7a56c011ddc533507650f
19461946
ReactCodegen: 4e26d365313307cc7c95e693529e539acfb5c64c
19471947
ReactCommon: 422e364463f33e336fc4db196aeb50fd801d90d6
1948-
RNNitroSQLite: 4b26e2a5b46a029ee3a90daccf01de958e3dd067
1948+
RNNitroSQLite: 8ce92f88831267a0300a4069aea75d7a445b8039
19491949
RNScreens: e389d6a6a66a4f0d3662924ecae803073ccce8ec
19501950
SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
19511951
Yoga: db69236006b8b1c6d55ab453390c882306cbf219
19521952

1953-
PODFILE CHECKSUM: 27ad3045377187b09e7ab4a604c851aa9838f52d
1953+
PODFILE CHECKSUM: 242b3bdf23dcca8e62d0c5651b11f41cdefac2d6
19541954

19551955
COCOAPODS: 1.15.2

β€Žpackage.jsonβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"patch-package": "^8.0.0",
3232
"react": "18.3.1",
3333
"react-native": "0.76.1",
34-
"react-native-nitro-modules": "0.20.1"
34+
"react-native-nitro-modules": "0.24.1"
3535
},
3636
"devDependencies": {
3737
"@babel/core": "^7.25.2",
@@ -57,7 +57,7 @@
5757
"eslint-config-prettier": "^9.1.0",
5858
"eslint-plugin-prettier": "^5.2.1",
5959
"jest": "^29.7.0",
60-
"nitro-codegen": "0.20.1",
60+
"nitro-codegen": "^0.24.1",
6161
"prettier": "^3.3.3",
6262
"release-it": "^17.10.0",
6363
"typescript": "~5.5.4",

β€Žpackage/cpp/operations.cppβ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ SQLiteExecuteQueryResult sqliteExecute(const std::string& dbName, const std::str
181181
const void* blob = sqlite3_column_blob(statement, i);
182182
uint8_t* data = new uint8_t[blob_size];
183183
memcpy(data, blob, blob_size);
184-
row[column_name] = ArrayBuffer::makeBuffer(data, blob_size, [&data]() -> void { delete[] data; });
184+
row[column_name] = ArrayBuffer::wrap(data, blob_size, [&data]() -> void { delete[] data; });
185185
break;
186186
}
187187
case SQLITE_NULL:

β€Žpackage/nitrogen/generated/.gitattributesβ€Ž

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žpackage/nitrogen/generated/android/RNNitroSQLite+autolinking.cmakeβ€Ž

Lines changed: 19 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žpackage/nitrogen/generated/android/RNNitroSQLiteOnLoad.cppβ€Ž

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žpackage/nitrogen/generated/android/RNNitroSQLiteOnLoad.ktβ€Ž

Lines changed: 0 additions & 1 deletion
This file was deleted.

β€Žpackage/nitrogen/generated/android/kotlin/com/margelo/nitro/rnnitrosqlite/RNNitroSQLiteOnLoad.ktβ€Ž

Lines changed: 35 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
Β (0)