fix lint errors in rnqc

Author: boorad

bun.lockb

@@ -7,7 +7,8 @@
     "android": "react-native run-android",
     "ios": "react-native run-ios",
     "clean": "del-cli android/build node_modules/**/android/build lib",
-    "lint": "eslint \"**/*.{js,ts,tsx}\" --fix",
+    "lint": "eslint \"**/*.{js,ts,tsx}\"",
+    "lint-fix": "eslint \"src/**/*.{js,ts,tsx}\" --fix",
     "start": "react-native start",
     "pods": "cd ios && RCT_NEW_ARCH_ENABLED=1 pod install && rm -rf .xcode.env.local",
     "build:android": "cd android && ./gradlew assembleDebug --no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a",

example/package.json

@@ -1,25 +1,40 @@
-module.exports = {
-  root: true,
-  extends: [
-    "@react-native",
-    "prettier"
-  ],
-  rules: {
-    "prettier/prettier": [
-      "warn",
-      {
-        "object-curly-spacing": ["always"],
-        quoteProps: "consistent",
-        singleQuote: true,
-        tabWidth: 2,
-        trailingComma: "es5",
-        useTabs: false,
-        semi: true,
-      }
-    ]
+import { fixupPluginRules } from '@eslint/compat';
+import js from '@eslint/js';
+import eslintReactNative from 'eslint-plugin-react-native';
+import typescriptEslint from 'typescript-eslint';
+
+export default typescriptEslint.config(
+  {
+    plugins: {
+      '@typescript-eslint': typescriptEslint.plugin,
+    },
+    languageOptions: {
+      parser: '@typescript-eslint/parser',
+      parserOptions: {
+        // project: './tsconfig.json',
+        projectService: true,
+      },
+    },
+    rules: {},
   },
-  ignorePatterns: [
-    "node_modules/",
-    "lib/"
-  ]
-};
+  js.configs.recommended,
+  ...typescriptEslint.configs.recommended,
+  // react-native
+  {
+    name: 'eslint-plugin-react-native',
+    plugins: {
+      'react-native': fixupPluginRules({
+        rules: eslintReactNative.rules,
+      }),
+    },
+    rules: {
+      ...eslintReactNative.configs.all.rules,
+      'react-native/sort-styles': 'off',
+      'react-native/no-inline-styles': 'warn',
+    },
+  },
+  // don't lint config files
+  {
+    ignores: ['.prettierrc.js', '*.config.js'],
+  },
+);

packages/react-native-quick-crypto/eslint.config.js

@@ -2,6 +2,7 @@
   "name": "react-native-quick-crypto",
   "version": "1.0.0-rc.0",
   "description": "A fast implementation of Node's `crypto` module written in C/C++ JSI",
+  "type": "module",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",
   "types": "lib/typescript/index.d.ts",
@@ -30,7 +31,8 @@
   "scripts": {
     "tsc": "tsc --noEmit",
     "typescript": "tsc --noEmit",
-    "lint": "eslint \"**/*.{js,ts,tsx}\"",
+    "lint": "eslint \"src/**/*.{js,ts,tsx}\"",
+    "lint-fix": "eslint \"src/**/*.{js,ts,tsx}\" --fix",
     "prepare": "bob build",
     "release": "release-it",
     "test": "jest"
@@ -70,16 +72,15 @@
     "util": "0.12.5"
   },
   "devDependencies": {
-    "@jamesacarr/eslint-formatter-github-actions": "0.2.0",
+    "@eslint/compat": "^1.1.1",
+    "@eslint/js": "^9.9.0",
     "@release-it/conventional-changelog": "8.0.1",
-    "@stylistic/eslint-plugin": "^2.6.2",
     "@types/jest": "29.5.11",
     "@types/node": "22.0.0",
     "@types/react": "18.3.3",
     "@types/readable-stream": "4.0.11",
-    "eslint": "8.57.0",
-    "eslint-config-prettier": "9.1.0",
-    "eslint-plugin-prettier": "5.2.1",
+    "eslint": "9.9.0",
+    "eslint-plugin-react-native": "^4.1.0",
     "jest": "29.7.0",
     "nitro-codegen": "0.3.0",
     "prettier": "3.2.5",
@@ -88,7 +89,8 @@
     "react-native-builder-bob": "0.29.0",
     "react-native-nitro-modules": "0.3.0",
     "release-it": "17.6.0",
-    "typescript": "5.1.6"
+    "typescript": "5.1.6",
+    "typescript-eslint": "^8.0.1"
   },
   "peerDependencies": {
     "react": "*",

packages/react-native-quick-crypto/package.json

@@ -32,12 +32,12 @@ export function randomFill<T extends ArrayBufferView>(
   callback: (err: Error | null, buf: T) => void
 ): void;
 
-export function randomFill(buffer: ArrayBufferView, ...rest: any[]): void {
+export function randomFill(buffer: ArrayBufferView, ...rest: unknown[]): void {
   if (typeof rest[rest.length - 1] !== 'function') {
     throw new Error('No callback provided to randomFill');
   }
 
-  const callback = rest[rest.length - 1] as any as (
+  const callback = rest[rest.length - 1] as unknown as (
     err: Error | null,
     buf?: ArrayBuffer
   ) => void;
@@ -46,12 +46,12 @@ export function randomFill(buffer: ArrayBufferView, ...rest: any[]): void {
   let size: number = buffer.byteLength;
 
   if (typeof rest[2] === 'function') {
-    offset = rest[0];
-    size = rest[1];
+    offset = rest[0] as number;
+    size = rest[1] as number;
   }
 
   if (typeof rest[1] === 'function') {
-    offset = rest[0];
+    offset = rest[0] as number;
   }
 
   getNative();
@@ -158,12 +158,12 @@ export function randomInt(
     typeof arg2 === 'undefined' || typeof arg2 === 'function';
 
   if (minNotSpecified) {
-    callback = arg2 as any as undefined | RandomIntCallback;
+    callback = arg2 as undefined | RandomIntCallback;
     max = arg1;
     min = 0;
   } else {
     min = arg1;
-    max = arg2 as any as number;
+    max = arg2 as number;
   }
   if (typeof callback !== 'undefined' && typeof callback !== 'function') {
     throw new TypeError('callback must be a function or undefined');
@@ -219,7 +219,7 @@ export function randomInt(
     if (x < randLimit) {
       const n = (x % range) + min;
       if (isSync) return n;
-      process.nextTick(callback as Function, undefined, n);
+      process.nextTick(callback as RandomIntCallback, undefined, n);
       return;
     }
   }
@@ -294,9 +294,7 @@ export function randomUUID() {
   randomFillSync(buffer, 0, size);
 
   // Per 4.4, set bits for version and `clock_seq_hi_and_reserved`
-  // eslint-disable-next-line no-bitwise
   buffer[6] = (buffer[6]! & 0x0f) | 0x40;
-  // eslint-disable-next-line no-bitwise
   buffer[8] = (buffer[8]! & 0x3f) | 0x80;
 
   return (

packages/react-native-quick-crypto/src/random.ts

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "composite": true,
     "outDir": "lib",
-    "rootDir": "src",
+    "rootDir": ".",
     "allowUnreachableCode": false,
     "allowUnusedLabels": false,
     "esModuleInterop": true,
@@ -25,5 +25,6 @@
     "target": "esnext",
     "verbatimModuleSyntax": true,
   },
-  "include": ["src"]
+  "include": ["src"],
+  "exclude": ["zzz"]
 }