fix: PR feedback and test fix for string args

Author: boorad

.rules

@@ -1,53 +1,55 @@
 # React Native Quick Crypto
 
-Every time you choose to apply a rule(s), explicitly state the rule(s) in the output You can abbreviate the rule description to a single word or phrase.
+Every time you choose to apply a rule(s), explicitly state the rule(s) in the output. You can abbreviate the rule description to a single word or phrase.
 
 ## Project Context
-- This is a react native project that offers cryptographic operations in native
-code.
+
+- This is a React Native project that offers cryptographic operations in native code.
 - It uses Nitro Modules to bridge JS & C++.
-- Use the documentation of Nitro Modules if you have access locally to its llms.txt file.
-- Part of the API strives to be a polyfill of the Node.js {crypto} module.
+- Use the documentation of Nitro Modules if you have access locally to its `llms.txt` file.
+- Part of the API strives to be a polyfill of the Node.js `{crypto}` module.
 - The goal is to migrate 0.x of this library that uses OpenSSL 1.1.1 to now use OpenSSL 3.3 and modern C++ with Nitro Modules.
 
 ## Tech Stack
+
 - React Native
-- Typescript
+- TypeScript
 - Nitro Modules
 - C++ 20 and higher, modern
 - OpenSSL 3.3 and higher
 - TypeScript package manager is `bun` 1.2 or higher
-- don't ask to run tests.  They have to be run in an example React Native app.
+- Don't ask to run tests. They have to be run in an example React Native app.
 
 ## Rules
-- for C++ includes, do not try to add absolute or relative paths.  They have to be resolved by the build system.
-- use smart pointers in C++
-- use modern C++ features
+
+- For C++ includes, do not try to add absolute or relative paths. They have to be resolved by the build system.
+- Use smart pointers in C++.
+- Use modern C++ features.
 - Attempt to reduce the amount of code rather than add more.
 - Prefer iteration and modularization over code duplication.
 
-# TypeScript Best Practices
+## TypeScript Best Practices
 
 - Use TypeScript for all code; prefer interfaces over types.
-- Use lowercase with dashes for directories (e.g., components/auth-wizard).
+- Use lowercase with dashes for directories (e.g., `components/auth-wizard`).
 - Favor named exports for components.
-- Avoid any and enums; use explicit types and maps instead.
+- Avoid `any` and enums; use explicit types and maps instead.
 - Use functional components with TypeScript interfaces.
 - Enable strict mode in TypeScript for better type safety.
 - Suggest the optimal implementation considering:
   - Performance impact
   - Maintenance overhead
   - Testing strategy
-- Code examples should follow Typescript best practices.
+- Code examples should follow TypeScript best practices.
 
-# React Best Practices
+## React Best Practices
 
-- Minimize the use of useEffect. They should be a last resort.
-- Use named functions for useEffects with a meaningful function name. Avoiding adding unnecessary comments on effect behavior.
+- Minimize the use of `useEffect`. They should be a last resort.
+- Use named functions for `useEffect`s with a meaningful function name. Avoid adding unnecessary comments on effect behavior.
 
-# Syntax & Formatting
+## Syntax & Formatting
 
-- Use the function keyword for pure functions.
+- Use the `function` keyword for pure functions.
 - Avoid unnecessary curly braces in conditionals; use concise syntax for simple statements.
 - Use declarative JSX.
 - Use Prettier for consistent code formatting.

example/src/tests/cipher/cipher_tests.ts

@@ -92,8 +92,8 @@ function roundTripAuth(
 // Helper for non-authenticated modes
 function roundTrip(
   cipherName: string,
-  key: Buffer,
-  iv: Buffer,
+  key: Buffer | string,
+  iv: Buffer | string,
   plaintext: Buffer,
 ) {
   // Encrypt
@@ -112,13 +112,7 @@ function roundTrip(
   expect(decrypted).eql(plaintext); // Use Chai's eql for deep equality
 }
 
-// Helper function to generate random data (commented out as it's unused and incomplete)
-/* ... existing generateCipherData function ... */
-
 // --- Tests ---
-const allCiphers = getCiphers();
-// .filter(c => c.includes('SIV'))
-// .filter(c => c.includes('CCM') || c.includes('OCB'))
 test(SUITE, 'valid algorithm', () => {
   expect(() => {
     createCipheriv('aes-128-cbc', Buffer.alloc(16), Buffer.alloc(16), {}); // Use alloc
@@ -135,24 +129,24 @@ test(SUITE, 'strings', () => {
   // roundtrip expects Buffers, convert strings first
   roundTrip(
     'aes-128-cbc',
-    key, // Use globally defined key
-    iv, // Use globally defined iv
-    plaintextBuffer, // Use the correct plaintext buffer
+    key.toString('hex'),
+    iv.toString('hex'),
+    plaintextBuffer,
   );
 });
 
 test(SUITE, 'buffers', () => {
   roundTrip(
     'aes-128-cbc',
-    key, // Use globally defined key
-    iv, // Use globally defined iv
-    plaintextBuffer, // Use the correct plaintext buffer
+    key,
+    iv,
+    plaintextBuffer,
   );
 });
 
-// --- Main test dispatcher ---
+// loop through each cipher and test roundtrip
+const allCiphers = getCiphers();
 allCiphers.forEach(cipherName => {
-  // Define a test for each cipher algorithm
   test(SUITE, cipherName, () => {
     try {
       // Determine correct key length
@@ -162,7 +156,6 @@ allCiphers.forEach(cipherName => {
       } else if (cipherName.includes('192')) {
         keyLen = 24;
       }
-      // Always use Uint8Array for testKey generation
       let testKey: Uint8Array;
       if (cipherName.includes('XTS')) {
         keyLen *= 2; // XTS requires double length key
@@ -200,14 +193,11 @@ allCiphers.forEach(cipherName => {
         cipherName.includes('Poly1305') ||
         cipherName.includes('SIV') // SIV modes also use auth
       ) {
-        // Pass aad buffer defined globally
         roundTripAuth(cipherName, key, iv, plaintextBuffer, aad);
       } else {
         roundTrip(cipherName, key, iv, plaintextBuffer);
       }
     } catch (e: unknown) {
-      // console.error(`Error testing cipher ${cipherName}:`, e.message, e.stack);
-      // Use Chai's expect to fail the test explicitly on error
       const message = e instanceof Error ? e.message : String(e);
       expect.fail(`Cipher ${cipherName} threw an error: ${message}`);
     }