esp_yield() and esp_schedule()

[adynis]

Until now, these functions existed in the code but were not used, because:

// Let's go!
if (ping_start(&_options)) {
    return true;
    // Suspend till the process end
    esp_yield();
}
return (_success > 0);

ping_start(....) is immediately returning, so if true, then it returns before running esp_yield() and if false, then esp_yield() is not triggered.

and

esp_schedule() was in the callback function which (as mentioned in issue #6 ) was never called.

Since we have issues: #6, #8 , #9 , how should : esp_yield() and esp_schedule() be treated ?

PS. I have no proposal here, since I am not familiar with these 2. I'm not sure about their functionality.

[adynis]

Now I've just seen that the 2 functions are actually empty .... I thought that they are something official ... 🙄
Was there any intention with these ?
Should these be removed/commented out ?

[marian-craciunescu]

esp_yield should help returning immeditally from the current function/ISR
in order to continue the execution of the other task ion the processors.it's wront I think with the order. Should be yield and then return

[marian-craciunescu]

esp_yield() is "switch from sketch context to scheduler context".
esp_schedule() is "make scheduler resume the sketch at next opportunity"

[adynis]

I'm not familiar with these functions.
But I observed also this in the code:

ESP32Ping/ESP32Ping.cpp

Lines 22 to 23 in 8aab829

	extern "C" void esp_schedule(void) {};
	extern "C" void esp_yield(void) {};