-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support different package indexes for html-wasm notebooks #3831
Comments
Does your index mirror PyPI? this is a bit tricky since there are many pre-built packages by the Pyodide camptaible for WASM, that exist on PyPI? Will these packages exist on your index? |
Yeah, we have a full mirror of PyPI (Really it has a pass through), but also enables us to use private internal packages that are not on pypy. But it sounds like maybe internal packages would not work with with Pyodide and WASM as well. |
@damienrj the internal packages would work if they are pure-python (i.e. no C or Rust bindings) and you publish a wheel for them |
Yeah, pretty much just pure python on top of public libraries with wheels.
…On Tue, Feb 18, 2025, 12:10 PM Myles Scolnick ***@***.***> wrote:
@damienrj <https://github.com/damienrj> the internal packages would if
they are pure-python (i.e. no C or Rust bindings) and you publish a wheel
for them
—
Reply to this email directly, view it on GitHub
<#3831 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAU2KQ5SBX3GYQSSBK5MVYD2QOHUDAVCNFSM6AAAAABXMDL7JGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRWHAZTGNRZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: mscolnick]*mscolnick* left a comment (marimo-team/marimo#3831)
<#3831 (comment)>
@damienrj <https://github.com/damienrj> the internal packages would if
they are pure-python (i.e. no C or Rust bindings) and you publish a wheel
for them
—
Reply to this email directly, view it on GitHub
<#3831 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAU2KQ5SBX3GYQSSBK5MVYD2QOHUDAVCNFSM6AAAAABXMDL7JGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRWHAZTGNRZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This might be a decent refactor. there are two options for implementation:
For timeline:
|
Yeah that makes sense, I think given that it is more for enterprise that #2 would make the most sense to not interfere with non-enterprise setups. I will demo it more without the VPN off first, and I am happy to take a stab at contributing. However, I think with my company policy I am more limited to contributing to open sourced part of the code since you mentioned that part is closed source. (Also thanks for your replies) |
If it were possible to implement both of these options that would be of a great help on some of my use cases as well in an internal company network. We have CDN and pypi mirrors, but being able to specify a custom |
@Ryanphoenix the regex is not a bad solution. Our front end assets are already pre-built, so it would be hard to parameterize this, and the actual implementation may be regexs as well. The lockfile is a bit trickier. You could completely remove it and see if that works (it might append the correct index). If you are open to sharing your snippet, maybe it's something that can help for our implementation. |
@mscolnick yeah, happy to share the snippet for the regex. I ended up pulling down a version of the pyodide distro, and using their lockfile (plus the marimo specific bits). VERY hacky way around things, but being able to say "here's my pypi mirror, the link to my specific (compatible) pyodide distro, and my specific lock-file" when generating the wasm and having some regex that goes in behind the scenes to overwrite them with the user's values would at least take a few steps out, and also let me not have to upload al of the |
This is my super hacky way of doing it. Pretty much was a trial and error of using gitlab ci/cd to deploy the page, then looking to see which resource was failing to load and then finding a regex pattern for it. I hand jammed this on my personal computer so I might've accidentally introduced a typo here or there, but hopefully gets you into the right ballpark!
|
Description
Hello,
On our company network we can not access pypi directly and instead have our own index that we use. This means we can't use a WASM notebook and be on the company network at the same time since otherwise packages fail to install. Having a way to support more than one package index would be great.
Suggested solution
Enable notebooks to use different package indexes.
Alternative
No response
Additional context
The text was updated successfully, but these errors were encountered: