-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mep/8: frontend function hints #4025
base: dm/setup-context
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
for more information, see https://pre-commit.ci
No brand docs yet ... but that's a good idea. At first glance it feels a bit repetitive to include the function signature in the output area? I like the idea of communicating hints and function-ness though ... |
@dmadisetti is the name configurable on the frontend? is it enforced by the backend? when happens to the name if it goes from a pure function to non-pure function? |
Name will be overwritten as is, which seems reasonable? But the current UI does make it a bit jarring. Might be worth hiding in these cases.
Then the TopLevelStatus "hint" indicates that something has gone wrong- but the name is retained. It could be pushed back to "_" Currently unindented comments after (or before) the function are stripped. I'm think we should retain the comments, and have that break "purity" if someone really wanted to intentionally keep it in cell mode. |
Agreed. I think this is an issue shared with markdown too. Many possible UIs but one might be using the markdown style blocks of no border, and expansion on click |
📝 Summary
@mscolnick this was my very rough draft approach to passing hints upstream:
For reference, this is how observable renders their functions:
and what was suggested:
But I'm sure there's probably a more cohesive marimo style (do we have have any brand docs?):