Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websockets #1

Open
joshuarossi opened this issue Jul 23, 2016 · 3 comments
Open

Websockets #1

joshuarossi opened this issue Jul 23, 2016 · 3 comments

Comments

@joshuarossi
Copy link

This is a really great library! We want to add it to the docs at docs.bitfinex.com, but would it be possible to add support for websockets?

@mariodian
Copy link
Owner

mariodian commented Jul 24, 2016

Hey Joshua thanks!

To tell you do truth I haven't even heard of "client" side websockets up until now. I may be wrong but from what I know about PHP it's by far one of the worst languages to handle open connections for a longer period of time. I assume you'd have to hack a lot of things so you don't run out of resources.

I googled some libraries (Devristo/phpws, Textalk/websocket-php etc) and they are rather complex and often dependent on another libs.

I'm sorry but I don't see myself adding WS support to this lib.

@joshuarossi
Copy link
Author

no problem, maybe i could give it a shot? I'll submit a PR if I can get it to work

@mariodian
Copy link
Owner

Sure no problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants