Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Footnotes #7

Open
mitsuhiko opened this issue Dec 11, 2022 · 13 comments
Open

Add Footnotes #7

mitsuhiko opened this issue Dec 11, 2022 · 13 comments

Comments

@mitsuhiko
Copy link

Not sure if this is something that belongs into the core plugin selection, but the main missing feature I came across are footnotes.

@digitalmoksha
Copy link

+1 for footnote support as a provided plugin. It would be great to have full GFM support built-in - I'm thinking of parity with cmark-gfm. It's already pretty darn close.

@digitalmoksha
Copy link

I think we would just need a port of https://github.com/markdown-it/markdown-it-footnote, wouldn't have to be included in this package

@digitalmoksha
Copy link

@rlidwka Are there any difficulties you see, if I were to attempt to port markdown-it-footnote into Rust, or have you by chance already started that?

@rlidwka
Copy link
Collaborator

rlidwka commented May 8, 2023

Are there any difficulties you see, if I were to attempt to port markdown-it-footnote into Rust, or have you by chance already started that?

No, I didn't start it yet. You're very welcome to submit a PR or publish it as a separate crate.

@chrisjsewell
Copy link
Member

chrisjsewell commented Jun 22, 2023

Heya, all done, plus tasklists etc 😄 https://github.com/chrisjsewell/markdown-it-plugins.rs -> https://crates.io/crates/markdown-it-footnote, ...
(feedback definitely welcome!)

and also, added bonus ✨, it gave the opportunity to play around with Python bindings for Rust: https://github.com/chrisjsewell/markdown-it-pyrs

Its all released and working well although, as I was creating these, I made a big list of things to feedback here: https://github.com/chrisjsewell/markdown-it-pyrs#todo
Maybe I can open some issues for these here and also, when I find more time, some PRs

@rlidwka
Copy link
Collaborator

rlidwka commented Aug 4, 2023

@chrisjsewell, what are your intentions regarding those plugins?

I've noticed that it has approximately the same kind of things as in src/plugins/extras here, there's even an overlap (anchors).

May I suggest we find a way to work together on all markdown-it rust plugins?

Can move them all here (I can give you access, and make this repo into workspace). Or we can move all extra plugins (strikethrough and such) to your repository, and I only focus on pure cmark here. Or maybe create a new organization for markdown-it-rust specifically?

@chrisjsewell
Copy link
Member

Heya @rlidwka, yep definitely interested to work together 👍

As you can see in markdown-it-rust/markdown-it-plugins.rs#19, I just added a (just about) fully spec compliant GFM plugin 🎉
This incorporates the anchors plugin, that is designed to allow for GitHub compliance, which the plugin in this repo does not.

My main intention was to start having the "major" CommonMark extensions supported with markdown-it.rs, and also others from https://github.com/executablebooks/mdit-py-plugins.
Then also eventually look into if I could implement a https://myst-parser.readthedocs.io implementation,
and even a complimentary reStructureText parser

I think making a markdown-it-rust organisation makes sense, so that this repo can be the "more stable" base implementation,
and then indeed I can move my repo to the org

@rlidwka
Copy link
Collaborator

rlidwka commented Aug 7, 2023

I think making a markdown-it-rust organisation makes sense, so that this repo can be the "more stable" base implementation, and then indeed I can move my repo to the org

Okay, I'll set it up sometime soon.

@chrisjsewell, do you have a Discord? Or any other place we can discuss it in realtime?

@chrisjsewell
Copy link
Member

do you have a Discord? Or any other place we can discuss it in realtime?

Hmm, no specific discord, I guess feel free to get in touch via [email protected]

@rlidwka
Copy link
Collaborator

rlidwka commented Aug 19, 2023

@chrisjsewell, I've added a organization for this, invited you as owner.

The most important question here: do you have any suggestion for organization logo?

Hmm, no specific discord, I guess feel free to get in touch

Nah I was hoping for more quick communication channel. Email is basically the same as github issues here.

You don't have any chat for user support for your python projects? Like markdown-it has gitter for this, although I haven't been following it.

@chrisjsewell
Copy link
Member

chrisjsewell commented Aug 30, 2023

do you have any suggestion for organization logo?

Oh I do 😄: https://www.figma.com/file/UQMOXPceC59IgWzvStffC2/markdown-it?type=design&node-id=0%3A1&mode=design&t=BhSWUqRf0AjDprFf-1

For markdown-it in general:

markdown-it

For markdown-it.rs

markdown-it rs

for markdown-it-py

markdown-it-py

@chrisjsewell
Copy link
Member

Nah I was hoping for more quick communication channel
You don't have any chat for user support for your python projects?

Not so much, normally just use github issues/discussion; rest of communication is email, slack channels, ms teams, whatsapp, ... too many these days already 😅

I just joined the markdown-it gitter if thats helpful

@digitalmoksha
Copy link

@chrisjsewell Nice job putting all those together! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants