Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to \MarketoApi namespace #7

Open
Jaesin opened this issue Oct 12, 2016 · 4 comments
Open

Move to \MarketoApi namespace #7

Jaesin opened this issue Oct 12, 2016 · 4 comments

Comments

@Jaesin
Copy link

Jaesin commented Oct 12, 2016

This should be done at the time of a 1.0 release but not before.

@itmayziii
Copy link
Collaborator

@Jaesin Why not before?

@itmayziii
Copy link
Collaborator

@Jaesin I have added some notes for the project, let me know what you think about those TODO items. I agree we need more testing around everything. In my opinion I think we should aim to cover every endpoint Marketo offers in their REST services. That would mean we have a lot more to add and we might consider breaking up the Client.php file, I was thinking of breaking it up like this?

  • Src
    • Request
      ( This is the way Marketo breaks up the endpoints in the documenation)
      • Lead Database
        • Companies.php
        • Leads.php
        • etc...
      • Asset
        • Channels.php
        • Emails.php
        • etc...
      • Authentication
    • Response
      • All the response classes.php

@Jaesin
Copy link
Author

Jaesin commented Oct 25, 2016

As far as not chaging the namespace before a 1.0, we are using this library in some projects that will need minor refactoring. That said, I think we need to create a point release.

As far as implementing new client calls. I would like to see us writing less code and using the services.json file as much as possible. The reason being is that there will be changes in guzzle services for major version upgrades and I plan to make this library guzzle 6 compatible. The services.json file hasn't changed so a guzzle major version upgrade should be very easy as long as there isn't much code.

For guzzle 6, we need a middleware for oauth2 and the services.json file. It would be quite nice if that was all we needed.

guzzle/guzzle-services#109
commerceguys/guzzle-oauth2-plugin#29

@PancakeTornado
Copy link

README.md will also need its namespace references updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants