Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rems #5

Open
VinSpee opened this issue Nov 13, 2015 · 6 comments
Open

rems #5

VinSpee opened this issue Nov 13, 2015 · 6 comments

Comments

@VinSpee
Copy link

VinSpee commented Nov 13, 2015

I'd love for this to output rems, is that possible?

@markgoodyear
Copy link
Owner

@VinSpee This should be possible yes. I need to update the plugin for the latest PostCSS, so I'll look to add this in with it.

@markgoodyear
Copy link
Owner

In fact, I'll push the rem's back for a feature release as I think it'll need some testing. Rem output is going to depend on where the font-size declaration is set, and then will need to account for if it's originally set in rem too.

@VinSpee How do you typically set up a project in terms of the above?

@BarryThePenguin
Copy link

If it helps, I use px-to-rem. I prefer the idea of keeping plugins/modules to a small maintainable set of features

@markgoodyear
Copy link
Owner

I use that to for projects instead of Sass mixins. I find it works really well, being able to whitelist/blacklist properties is very handy. Perhaps it could be worth a try before implementing rem output @VinSpee?

@VinSpee
Copy link
Author

VinSpee commented Nov 19, 2015

I will definitely try that, but one could argue the opposite - that this library should only do rems and to  use rem-to-px to convert lol. 

All in all I think the conversion should be a fine solution. 

(null)

On Wed, Nov 18, 2015 at 6:23 PM, Mark Goodyear [email protected]
wrote:

I use that too for projects instead of Sass mixins. I find it works really well, being able to whitelist/blacklist properties is very handy. Perhaps it could be worth a try before implementing rem output @VinSpee?

Reply to this email directly or view it on GitHub:
#5 (comment)

@ghost
Copy link

ghost commented Jun 1, 2016

I might be late in the conversation but since the issue is still open, and since I just started using this too, I'll put my opinion:
Rem output is not going to depend on where the font-size declaration is set, it will always depend on the root size. So I think switching from px to rem should be fairly safe, unless I'm missing something else.
And as @BarryThePenguin says, px-to-rem could be another option, but it feels kinda awkward, it might be just me though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants