Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indonesian translation of slides #5

Open
marko-knoebl opened this issue Dec 9, 2020 · 8 comments
Open

Indonesian translation of slides #5

marko-knoebl opened this issue Dec 9, 2020 · 8 comments

Comments

@marko-knoebl
Copy link
Owner

Thanks @naufaldi for offering to translate React topics to Bahasa Indonesia.

I've set up a branch called react-translation-indonesian. There, I've started you off with an empty translation of the "react" topic.

I suggest you fork from there and start working from that point. Once the translation progresses, I'll integrate the changes into the main branch.

There's a little bit of information concerning contributing in the readme.md file, just ask if you have further questions!

One thing that we'll have to figure out in the future is how to handle topics that keep changing. So far, I've kept changing / optimizing sections quite a bit, maybe I can try to create more stable versions.

Of course, if you have any suggestions for changing things in the English version, do let me know!

Looking forward to working with you!

@naufaldi
Copy link

thanks you and sorry for late reply. if i can, can first translate Javascript first than going to ReactJS? So, i just need to fork and make different branch and start translate right? Than, make PR if finishing translate ?

thanks for your respon

@marko-knoebl marko-knoebl changed the title Indonesian translation of React topics Indonesian translation of slides Dec 11, 2020
@marko-knoebl
Copy link
Owner Author

oh alright, nice if you're planning to translate JavaScript topics too! I've made a more generic branch called "indonesian-translation", you can work from there. As an example there's still a starter for the indonesian translation of React in there, but you can delete that and start with another topic

Which JavaScript topics would you want to translate? Some of them are only available in German so far.

Keep me updated on how translation is going and I'd say once you've translated one or two topics we can start integrating the changes via pull requests!

@naufaldi
Copy link

Thanks, so i will work on branch "indonesian-translation" right? JavaScript topics about ES 2015+ and once, it finish will make PR than start with JavaScript: async and network requests. i will start today to translation.

@marko-knoebl
Copy link
Owner Author

Yes, you can work from "indonesian-translation".

I think I'll do some work/update on "async and network requests" today - maybe I can finish that before you start translating, so you can work on a more up-to-date version.

@marko-knoebl
Copy link
Owner Author

I didn't get around to redoing the section - but that would be something i'll do in the next weeks

@naufaldi
Copy link

Oke. Monday will working with translation in ES 2015 👍, if finish will making PR. Thanks you!

@marko-knoebl
Copy link
Owner Author

FYI, I've updated and renamed the "async and network requests" section - it's now called "JavaScript: Promises, Fetch and Axios" - you can rebase and translate from there.

@naufaldi
Copy link

@marko-knoebl Okee.. thanks you for your information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants