Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'h' is not defined #4

Open
knarfamlap opened this issue Aug 31, 2022 · 1 comment
Open

'h' is not defined #4

knarfamlap opened this issue Aug 31, 2022 · 1 comment

Comments

@knarfamlap
Copy link

Hi!

Thanks for sharing your cool walkthrough!

When combining the attention heads in the encoder, it seems like 'h' is not defined. Did you mean to say 'num_heads'?

Thanks!
@p0p4k
Copy link
Contributor

p0p4k commented Oct 27, 2022

Yes. That's correct.

timcrone added a commit to timcrone/transformer-walkthrough that referenced this issue Feb 16, 2024
@timcrone
Address issue markriedl#4
3a67a22 
There is a rogue 'h' where a 'num_heads' should be in the first unfold.  The output is correct, but when the notebook is rerun the variable h is undefined, leading to subsequent failures.
markriedl added a commit that referenced this issue Feb 20, 2024
@markriedl
Merge pull request #7 from timcrone/timcrone-issue-4
bb019d5 
Address issue #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@p0p4k @knarfamlap