New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It seems no weight matrices introduced? #5

Open

guruace opened this issue May 19, 2023 · 0 comments

guruace commented May 19, 2023

Thank you for the excellent work: computation graph with code. But there are two things.

It seems to me that no weight matrices are introduced either in the computation graph or in the coding. Maybe they are int he coding but I could not find it? Weights are the trainable parameters and are the key components in transformer architecture.
Could you upload a higher resolution file for the computation graph, or svg or pdf vector formats, since the one we see now is quite low resolution.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment