From 15672d2a028d6dbb9da1335db66588670c9d6742 Mon Sep 17 00:00:00 2001 From: Oliver Conzen Date: Mon, 17 Jun 2024 03:17:41 +0200 Subject: [PATCH] Remove extraneous flags (#38) --- zfs-inplace-rebalancing.sh | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/zfs-inplace-rebalancing.sh b/zfs-inplace-rebalancing.sh index 9e6afd4..82344ec 100755 --- a/zfs-inplace-rebalancing.sh +++ b/zfs-inplace-rebalancing.sh @@ -93,21 +93,19 @@ function rebalance () { # Linux # --reflink=never -- force standard copy (see ZFS Block Cloning) - # -a -- keep attributes - # -d -- keep symlinks (dont copy target) + # -a -- keep attributes, includes -d -- keep symlinks (dont copy target) and + # -p -- preserve ACLs to # -x -- stay on one system - # -p -- preserve ACLs too - cp --reflink=never -adxp "${file_path}" "${tmp_file_path}" + cp --reflink=never -ax "${file_path}" "${tmp_file_path}" elif [[ "${OSTYPE,,}" == "darwin"* ]] || [[ "${OSTYPE,,}" == "freebsd"* ]]; then # Mac OS # FreeBSD - # -a -- Archive mode. Same as -RpP. + # -a -- Archive mode. Same as -RpP. Includes preservation of modification + # time, access time, file flags, file mode, ACL, user ID, and group + # ID, as allowed by permissions. # -x -- File system mount points are not traversed. - # -p -- Cause cp to preserve the following attributes of each source file - # in the copy: modification time, access time, file flags, file mode, - # ACL, user ID, and group ID, as allowed by permissions. - cp -axp "${file_path}" "${tmp_file_path}" + cp -ax "${file_path}" "${tmp_file_path}" else echo "Unsupported OS type: $OSTYPE" exit 1