Would you accept a freebsd PR?

[duskmoss]

Hi just wondering if I made a little pull request that made the script run on freebsd (maybe also a bit in the read me about the dependencies for freebsd) would you accept it?

Just a few minor changes . So far just changes to sed and stat format. I'd test on freebsd and linux.

I know you don't use and rightly said you can't support FreeBSD, so I understand if you'd rather not have anything more that makes it look like you do.

[markusressel]

Sure thing! We just have to make sure that we test the changes on all platforms (Linux, FreeBSD, Mac).

[duskmoss]

I don't have a mac, if I get the PR ready would you be willing to test on Mac?

[markusressel]

Well I would, but I don't have a testing setup for all platforms either. Would be a great addition to the CI though.
In #41 OP used VMs to test other platforms, maybe we can do the same using GitHub Actions.

[duskmoss]

Okay, I'm not sure how to proceed on testin on mac then, but I'll open a PR that works on freebsd and linux at least. Since those are the main platforms, and what I'm doing shouldn't hit mac maybe thats enough, but we can go from there

[duskmoss]

I opened #44 I did end up changing things for mac... but looking at the manual pages I'm certain they were not working in the same way it wasn't for freebsd.

[markusressel]

Thx again @duskmoss , I will close this for now. Feel free to open a new issue if something comes up.

[duskmoss]

you're welcome!