Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make common substring highlight configurable #627

Open
kedricsty opened this issue Aug 7, 2023 · 1 comment · May be fixed by #727
Open

Make common substring highlight configurable #627

kedricsty opened this issue Aug 7, 2023 · 1 comment · May be fixed by #727
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kedricsty
Copy link

Environment

% typeset -p1 VENDOR OSTYPE ZSH_PATCHLEVEL _autocomplete__funcfiletrace
typeset VENDOR=apple
typeset OSTYPE=darwin22.0
typeset ZSH_PATCHLEVEL=zsh-5.9-0-g73d3173
typeset -a _autocomplete__funcfiletrace=(
  /Users/kedricseah/.oh-my-zsh/custom/plugins/zsh-autocomplete/zsh-autocomplete.plugin.zsh:4
  /Users/kedricseah/.oh-my-zsh/oh-my-zsh.sh:170
  /Users/kedricseah/.oh-my-zsh/oh-my-zsh.sh:199
  /Users/kedricseah/.zshrc:139
  zsh:0
)
% git -C ~autocomplete log --oneline -n1
6d059a3 (HEAD -> main, tag: 23.07.13, origin/main, origin/HEAD) Fix bugs in insertion logic
  • Operating system: macOS Ventura 13.5
  • Terminal emulator: iterm2

Steps to reproduce

  • git clone https://github.com/marlonrichert/zsh-autocomplete.git ${ZSH_CUSTOM:-~/.oh-my-zsh/custom}/plugins/zsh-autocomplete
  • added to plugins=(git web-search zsh-autosuggestions zsh-autocomplete zsh-syntax-highlighting)
  • typed: cd de
  • common substring: De appears with a highlight
Screenshot 2023-08-07 at 10 04 32 PM Screenshot 2023-08-07 at 10 05 17 PM Screenshot 2023-08-07 at 10 05 29 PM
  • I have tried disabling and enabling plugins one by one, even when zsh-autocompletion is the only plugin enabled, the highlighting is still seen

How do I remove/ change the highlighting color?

Contents of ~autocomplete-log/YYYY-MM-DD.log (click to expand)

@kedricsty kedricsty added the bug Something isn't working label Aug 7, 2023
@marlonrichert marlonrichert changed the title highlighting on common substring Make common substring highlight configurable Aug 16, 2023
@marlonrichert marlonrichert added enhancement New feature or request and removed bug Something isn't working labels Aug 16, 2023
@marlonrichert
Copy link
Owner

That's currently not configurable, but it could be made so.

@marlonrichert marlonrichert added the good first issue Good for newcomers label Aug 16, 2023
@mattiacerutti mattiacerutti linked a pull request Jun 17, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants