Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try decomposing with Cells #47

Closed
marnen opened this issue Apr 10, 2020 · 3 comments · Fixed by #48
Closed

Try decomposing with Cells #47

marnen opened this issue Apr 10, 2020 · 3 comments · Fixed by #48
Assignees
@marnen
Labels
chore Engineering task with not much direct user value experiment Something that will take some testing out to determine if it's even worth doing.

Comments

@marnen
Copy link
Owner

marnen commented Apr 10, 2020

The Cells gem seems like it would be useful at least for the state selector. I think it might be nice to take a little while to play around and see what else it could do for us.
@marnen marnen added chore Engineering task with not much direct user value experiment Something that will take some testing out to determine if it's even worth doing. labels Apr 10, 2020
@marnen
Copy link
Owner Author

marnen commented Apr 10, 2020 •
edited
Loading

Tabling this for now. I keep getting NoMethodError: undefined method `[]' for nil:NilClass when running Rails 6's form helpers in a cell, even with the proper helpers included. Grr.

@marnen
Copy link
Owner Author

marnen commented Apr 10, 2020 •
edited
Loading

Reported problem at trailblazer/cells#484. We'll see what they say.

@marnen marnen self-assigned this Apr 11, 2020
@marnen
Copy link
Owner Author

marnen commented Apr 11, 2020

I figured out the problem, so I'm giving this another try.

marnen added a commit that referenced this issue Apr 12, 2020
@marnen
Install cells-rails and cells-haml. [#47]
9c3fd97
marnen added a commit that referenced this issue Apr 12, 2020
@marnen
Add rspec-cells for testing. [#47]
198fd67
marnen added a commit that referenced this issue Apr 12, 2020
@marnen
Extract state selector to cell. [#47]
c41273a
marnen added a commit that referenced this issue Apr 12, 2020
@marnen
Move method from view into cell. [#47]
3430f70
marnen added a commit that referenced this issue Apr 12, 2020
@marnen
Use method instead of variable. [#47]
6eef2c6
marnen added a commit that referenced this issue Apr 12, 2020
@marnen
Move state list to cell. [#47]
457ac87
marnen added a commit that referenced this issue Apr 12, 2020
@marnen
Extract methods. [#47]
4defecf
marnen added a commit that referenced this issue Apr 14, 2020
@marnen
Have Guard watch cell view files as well as implementation files. [#47]
eb9b2fa
marnen added a commit that referenced this issue Apr 14, 2020
@marnen
Move state requests list to cell. [#47]
14a3fa8
marnen added a commit that referenced this issue Apr 14, 2020
@marnen
Move chart drawing logic to cell. [#47]
57f14da
marnen added a commit that referenced this issue Apr 14, 2020
@marnen
Use Cells API more idiomatically. [#47]
0d3a076
marnen added a commit that referenced this issue Apr 14, 2020
@marnen
Add a paragraph to the README about Cells. [#47]
21983dc
marnen added a commit that referenced this issue Apr 14, 2020
@marnen
Update changelog. [#47]
09e84e2
marnen added a commit that referenced this issue Apr 14, 2020
@marnen
rake gettext:find [#47]
f0e66f8
@marnen marnen linked a pull request Apr 14, 2020 that will close this issue
Introduce Cells [closes #47] #48
Merged
marnen added a commit that referenced this issue Apr 14, 2020
@marnen
Merge pull request #48 from marnen/47-cells
1c00d73 
Introduce Cells [closes #47]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marnen marnen

Labels
chore Engineering task with not much direct user value experiment Something that will take some testing out to determine if it's even worth doing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce Cells [closes #47] marnen/covid_tracking_charts
1 participant
@marnen