Skip to content

Issue in EFFORT computation for DEMO problems #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IvonArroyo opened this issue Aug 2, 2017 · 3 comments
Open

Issue in EFFORT computation for DEMO problems #362

IvonArroyo opened this issue Aug 2, 2017 · 3 comments
Assignees
Labels

Comments

@IvonArroyo
Copy link

Hi David and Neeraj,

There is a bug in the computation of student's effort. When a student sees a demo problem, the effort is logged as GIVEUP or alike.

Instead, effort should say EXAMPLE. Can this bug be fixed, and uploaded to the woj server (IDEALLY, to mathseeds also).
This error will be very obvious and unpleasant to teachers, as they see the reports in detail.

--IVON

@nsmenon
Copy link
Collaborator

nsmenon commented Aug 4, 2017

I think the Per Student Record that loads the Student efforts omits all records that are marked as demo problems. I am firing the below query which has the clause studentproblemhistory.mode != 'demo'

select sh.id,sh.problemId, pg.description,sh.problemEndTime,pr.name,pr.nickname, pr.statementHTML,pr.screenShotURL,sh.isSolved,sh.numMistakes,sh.numHints,sh.numAttemptsToSolve,sh.effort
from studentproblemhistory sh, problem pr, problemgroup pg where sh.studId in ( select id from student where classId=(:classId)) and sh.studId=(:studId)
and sh.mode != 'demo' and sh.problemId = pr.id and sh.topicId=pg.id order by sh.problemEndTime desc;

So I am not exactly sure what is to be done here (From Teacher Tools Standpoint)

--
Neeraj

@nsmenon nsmenon self-assigned this Aug 4, 2017
@nsmenon nsmenon added the NTT label Aug 4, 2017
@IvonArroyo
Copy link
Author

It is OK to ommit demo problems for the reports.

@IvonArroyo
Copy link
Author

Hi Neeraj and David,

This is still showing up and generating wrong impressions in the reports.
It would be nice to see that there was a specific problem shown as a worked out example.

DAVID, could we change the computeEffort method to encode EXAMPLE as an effort, if the problem had been seen as an example? I have the feeling that a lot of those problems that are missing effort (effort is null) is because of the examples.

--Ivon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants