Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavbarDropDownButton with bootstrap-4 incorrectly show #795

Open
bochkov-vi opened this issue Mar 27, 2019 · 3 comments
Open

NavbarDropDownButton with bootstrap-4 incorrectly show #795

bochkov-vi opened this issue Mar 27, 2019 · 3 comments

Comments

@bochkov-vi
Copy link

NavbarDropdownButton incorrectly renders button with attribute type="button"
its add border around of component and remove background color
to fix i need

.. new NavbarDropDownButton(...) {
      ....
        }.addToButton(new AttributeModifier("type",AttributeModifier.VALUELESS_ATTRIBUTE_REMOVE))....
@martin-g
Copy link
Owner

Please give some more information. It is nearly impossible to find out what should be fixed from this short description and code snippet.

@bochkov-vi
Copy link
Author

i use maven dependency
<wicket-bootstrap.version>3.0.0-M8</wicket-bootstrap.version>

NavbarDropDownButton extends DropDownButton
where in markup file
... <a class="dropdown-toggle" wicket:id="btn" type="button"
data-toggle="dropdown" aria-haspopup="true" href="javascript:;" aria-expanded="false">
...
type="button" makes NavbarDropDownButton show border and lost backgraund color

@bochkov-vi
Copy link
Author

I think it is necessary to make the "type" attribute customizable for baseButton
in DropDownButton class
when NavbarDropDownButton exending, remove it value from markup when initilizing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants