Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude the time of inserts from the time of finds #19

Open
renzibei opened this issue Jul 7, 2022 · 1 comment
Open

Exclude the time of inserts from the time of finds #19

renzibei opened this issue Jul 7, 2022 · 1 comment

Comments

@renzibei
Copy link
Contributor

renzibei commented Jul 7, 2022

The timing part of the current find has some issues to discuss. The time measured now includes the time used for inserts. The hash table is slowly expanded to its final size during the measurement. This brings two problems:

  1. The time we measured is not the time for find function. It's the time for find and insert. And when the number of elements in the hash table is larger, the ratio of the number of insert operations to the number of find operations is larger. So this problem is especially noticeable when the number of elements is large (e.g. RandomFind_500000).
  2. The time of RandomFind_N is not the time measured on a hash table of size N. It's the average time for all hash tables of size 1 to size N. This makes the results less informative for users who want to know the performance of a hash table of size N.

In summary, I think the method of measuring time in the find section should be improved.

@ktprime
Copy link
Contributor

ktprime commented Jul 7, 2022

I think it's a good ideal to improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants