Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unespected exception on filter function #577

Open
yhojann-cl opened this issue Jan 1, 2023 · 0 comments
Open

Unespected exception on filter function #577

yhojann-cl opened this issue Jan 1, 2023 · 0 comments

Comments

@yhojann-cl
Copy link

Have an unexpected error:

/.../node_modules/irc/lib/irc.js:849
                        throw err;
                        ^
TypeError: Cannot read properties of undefined (reading 'filter')
    at chanModes (/.../node_modules/irc/lib/irc.js:300:38)

The throw is called from:

        lines.forEach(function iterator(line) {
            if (line.length) {
                var message = parseMessage(line, self.opt.stripColors);

                try {
                    self.emit('raw', message);
                } catch (err) {
                    if (!self.conn.requestedDisconnect) {
                        throw err;
                    }
                }
            }
        });

When emit message, but in 300:38 says:

                            if (arr) {
                                channel.modeParams[mode] = channel.modeParams[mode]
                                    .filter(function(v) { return v !== param[0]; });
                            }
                            if (!arr || channel.modeParams[mode].length === 0) {
                                channel.mode = channel.mode.replace(mode, '');
                                delete channel.modeParams[mode];
                            }

When channel.modeParams[mode] is undefined. Channel has not a specific mode?, Fix it using a simple conditional:

                            if (arr && (channel.modeParams[mode] !== undefined)) {
                                channel.modeParams[mode] = channel.modeParams[mode]
                                    .filter(function(v) { return v !== param[0]; });
                            }
                            if (!arr || (channel.modeParams[mode] === undefined) || channel.modeParams[mode].length === 0) {
                                channel.mode = channel.mode.replace(mode, '');
                                delete channel.modeParams[mode];
                            }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant