Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support syncing inventory contents #8

Open
Shamus03 opened this issue Dec 8, 2022 · 3 comments
Open

Support syncing inventory contents #8

Shamus03 opened this issue Dec 8, 2022 · 3 comments

Comments

@Shamus03
Copy link

Shamus03 commented Dec 8, 2022

To be able to use the tweakInventoryPreview feature in Tweakeroo.

I think Tweakeroo already sends the required packet to request inventory contents from the server, Servux just doesn't respond to it. Is that right? I am pretty green on Minecraft modding but I would love to help however I can. I just want this feature to work.

@maruohon
Copy link
Owner

maruohon commented Dec 8, 2022

Inventory syncing was actually the first feature I started working on for Servux a few years back. But I didn't completely finish it yet, and then the structure bounding box stuff ended up being the first actually released feature, and the inventory syncing somehow got left in the back burner. I still have the syncing code in a separate branch somewhere.

And no, Tweakeroo (nor Litematica) does not yet send a packet to request it. That is actually one of the main things I haven't yet decided on how it should work - i.e. how and how often it should request for the data if you hold down the preview key.

@Shamus03
Copy link
Author

Shamus03 commented Dec 13, 2022

I think it would be enough, or at least a start, to sync the contents one time the first time the key is pressed or a new inventory is hovered. My main use case, and I'm sure it's the same for many others, is checking on inventories that I expect to be pretty static - especially in schematics for things like sorting systems, or anything else with sensitive inventory contents.

@mmodrow
Copy link

mmodrow commented Jul 19, 2023

Just to bump this: I'd totally dig this as a feature! It's pretty annoying not to be able to peep into shulker boxes, that lie inside a loader in a way, they cannot open. This is a very nice feature in single player to be able to look into inventories, that cannot be opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants