Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logger 도입 #95

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Logger 도입 #95

merged 6 commits into from
Sep 25, 2023

Conversation

seohyun0120
Copy link
Collaborator

🔥 관련 이슈

close #4

🔥 PR Point

  • NestJS에서 제공하는 Logger 4레벨(error, log, debug, warn) 추가
  • HTTP 요청 보냈을 때, 응답 받았을 때 로그 남기도록 함
  • HttpExceptionFilter에서도 error 로그 남김

이런식으로 로그 남음

[log] PATCH --> /user/nickname
[log] Get User - user({"userNo":1,"nickname":"서현","partnerNo":2}})
[error] PATCH 409 - 현재 유저는 이미 파트너 매칭이 완료되었습니다. - /user/nickname
[log] PATCH 409 7ms <-- /user/nickname

[log] PATCH --> /user/delPartner
[log] Get User - user({"userNo":1,"nickname":"서현","partnerNo":2}})
[debug] Delete Partner - userNo(1) partnerNo(2)
[log] Delete all challenges - userNo(1)
[log] PATCH 200 23ms <-- /user/delPartner

🔥 To Reviewers

  • 시범적으로 UserModule에 필요해보이는 로그 남겼고 추후에 나눠가져가서 로그 세세하게 달아주는 작업해야할 것 같아
  • debug랑 log 레벨이 조금 모호한데, 서비스에서 중간 과정은 debug로 남기고, 마지막에 모든 동작이 완료되었을 때 log로 남기도록 했는데 더 좋은 아이디어있으면 남겨줘

@seohyun0120 seohyun0120 changed the base branch from develop to feature/add-noti-challenge September 20, 2023 14:18
Hyun-git
Hyun-git approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@Hyun-git Hyun-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOOD~~ 드디어 로거가

@LouiMinister
Copy link
Collaborator

LGTM

@seohyun0120
Copy link
Collaborator Author

seohyun0120 commented Sep 24, 2023 •
edited
Loading

이거 94번 브랜치에 머지리퀘스트 달아둔거라 94번 완료되고 머지할게
@LouiMinister @Hyun-git

@Hyun-git Hyun-git merged commit 0df477d into feature/add-noti-challenge Sep 25, 2023
@seohyun0120 seohyun0120 deleted the feature/logging branch February 21, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyun-git Hyun-git Hyun-git approved these changes

@LouiMinister LouiMinister Awaiting requested review from LouiMinister

Assignees

@seohyun0120 seohyun0120

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logger 도입
3 participants
@seohyun0120 @LouiMinister @Hyun-git