Invalid file name

[mostafaznv]

Hi,
thanks for your nice package.

I have a problem with returned $filePath from onFinalized()
PATH_TO_FILE\...\videos\FC_Barcelona_vs_FC_Bayern_Munich_2015_（Champions_League_semi-final_Himno,Anthem ）.3gp

can you see spaces after ')' ?
It seems ） is not usual parentheses ) as we know
I can't generate link to the file! browser return 404 error

original video:
https://www.youtube.com/watch?v=sMq_A0ETURQ

[masihyeganeh]

Obviously this is related to pathSafeFilename function.
There are many possibilities for this to fail, including some non-English characters, some emojis and spaces.
PR is always welcome if you would. but there in Filename Sanitizing part of Readme, there is a way to change that function from outside of class. take a look at it.

[mostafaznv]

oh sorry!
I didn't see it. I will work on it and if I found a better solution, I will send a pull request.

I have another request about this package!
is there any way to change cache directory? I mean we can set video and cache directory as second and third parameters of __construct

many thanks.

[mostafaznv]

Hi again
I implemented a custom sanitizing function for my own project.
in my function, I convert all non-english characters to the same character in english (if you set default language to fa or ar, conversion will be disabled)

feel free to change any part of my code, if you don't like it

[mostafaznv]

any updates?

[masihyeganeh]

Could you test it again with the latest version?
Now using UTF8 package.

[mostafaznv]

I tested it with latest version (2.9.1)

but unfortunately file name generated with ）
without any success

[masihyeganeh]

Please give me link to that video

[mostafaznv]

https://www.youtube.com/watch?v=sMq_A0ETURQ

[mostafaznv]

any updates?

[masihyeganeh]

It is working in my PC

[mostafaznv]

As I said before, the problem is that ending parentheses.

please check attached image and link

[masihyeganeh]

As you can see, it is downloading the file and no error happened

[mostafaznv]

Yes I know. it downloaded for me too. but I can't generate download link for that in my website!
because file name has unknown characters for browser and browser return 404!

[masihyeganeh]

It's not the parentheses, it's the ending white space. I'll look into it

…

On Sun, Oct 28, 2018, 9:47 PM Mostafa Zeinivand ***@***.***> wrote: Yes I know. it downloaded for me too. but I can't generate download link for that in my website! because file name has unknown characters for browser and browser return 404! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#41 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAqQb3z-_a2no5yGGERbzh6MGqOYm4kjks5upfTXgaJpZM4T0uF7> .

[mostafaznv]

No. It's ending parentheses but I don't know the encoding of character. Please look at picture, It's a unit character I selected.