Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache the value of getMinimalFees #557

Open
Thykof opened this issue Apr 17, 2024 · 0 comments
Open

cache the value of getMinimalFees #557

Thykof opened this issue Apr 17, 2024 · 0 comments

Comments

@Thykof
Copy link
Contributor

Thykof commented Apr 17, 2024

getMinimalFees calls the RPC, so it's not optimal because while connected to a node, the minimal fee value will never change. We should find a way to prevent useless call to the RPC.

Proposal 1: add a class variable to PublicApiClient and set the value when undefined and return this value when defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant