callSmartContract should consider the candidate balance

[Thykof]

here

massa-web3/packages/massa-web3/src/web3/SmartContractsClient.ts

Line 153 in 3bdb27a

if (senderBalance.final < callData.coins) {

we check if the caller has enough funds to call the smart contract but we check the final balance of the caller. It prevents from calling the smart contract whereas the call it actually possible and will succeed.

It should check the candidate balance

cc @AurelienFT @Ben-Rey WDYT?

[Ben-Rey]

here

massa-web3/packages/massa-web3/src/web3/SmartContractsClient.ts

Line 153 in 3bdb27a

if (senderBalance.final < callData.coins) {

we check if the caller has enough funds to call the smart contract but we check the final balance of the caller. It prevents from calling the smart contract whereas the call it actually possible and will succeed.

It should check the candidate balance

cc @AurelienFT @Ben-Rey WDYT?

Can you give an example?

[Thykof]

• I have an account A in massa wallet that have 0 MAS
• using an account B that have MAS I send MAS to account A
• I switch to account A and I see the balance higher than zero
• I send FT token with the wallet, but it fails because account A MAS balance is not final

In anyway I think it's better to rely on the candidate balance in a more general case. I see no reason to enforce a final balance for a call sc, even more in massa-web3 lib.

[Ben-Rey]

Ok thanks, I agree