Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Creation of Events, service providers. #1419

Closed
wants to merge 5 commits into from

Conversation

abdullai-t
Copy link
Contributor

@abdullai-t abdullai-t commented Aug 21, 2024

Summary / Highlights

This PR addresses the issue where the forms for creating events and service providers were not working due to the inclusion of extra data fields that the backend was not expecting. These unnecessary fields have been removed, and the forms now function correctly.

Details (Give details about what this PR accomplishes, include any screenshots etc.)

My.Movie.mp4

Testing Steps (Provide details on how your changes can be tested)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've tested my changes manually.
  • I've added unit tests to my PR.
Transparency (Project board)
  • I've given my PR a meaningful title.
  • I linked this PR to the relevant issue.
  • I moved the linked issue from the "Sprint backlog" to "In progress" when I started this.
  • I moved the linked issue to "QA Verification" now that it is ready to merge.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Performance improvement
  • Feature removal
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch or to a feature branch, not the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the
    issue number)
  • All tests are
    passing:
  • New/updated tests are included

Other information: Any otherthing we need to know

frimpongopoku and others added 5 commits August 16, 2024 11:09
fix: fallback image now provided
Removed unnecessary null assignments for `vendor_id` and `action_id`
in `StoryForm.js`. This simplifies the code and avoids potential
conflicts.
By setting "IS_CANARY" to false, we ensure production stability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: service provider creation failing [Bug]: Event creation failing
2 participants