Inspect issues fix #34
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
The first part of ValveSoftware/Source-1-Games#4273
Implementation
This pr adds some checks to HandleInspect and some specific checks to tf_weapon_flamethrower, tf_weapon_dragons_fury and tf_weapon_grenadelauncher (for the Loose Cannon)
As said in the source issue tracker, a player can inspect when
Screenshots
pressing F as hard as I can
Desktop.2025.03.03.-.18.21.35.09.DVR.mp4
Desktop.2025.03.03.-.18.22.12.10.DVR.mp4
Desktop.2025.03.03.-.18.23.50.11.DVR.mp4
Desktop.2025.03.03.-.18.24.32.12.DVR.mp4
Desktop.2025.03.03.-.18.25.58.13.DVR.mp4
Checklist
tc2-modbranch.Testing Checklist
Caveats
When a player has just finished reloading with single reload weapons (shotgun etc) they can still inspect before the animation finishes. I couldn't get to the root and i think i would have to add more code to the reload code. For now i didn't want to do that.FIXED :DAlso, players with the Classic can inspect first and start to charge the gun or zoom. I haven't check how to fix that.
Maybe i could also add a debug convar but whatever
Alternatives
The checks for TF_COND_AIMING and TF_COND_ZOOMED could be moved to tf_weapon_sniperrifle? I'll check that later, but it works regardless