Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move training functions into model classes #203

Open
florian-huber opened this issue Feb 20, 2024 · 2 comments
Open

Move training functions into model classes #203

florian-huber opened this issue Feb 20, 2024 · 2 comments

Comments

@florian-huber
Copy link
Contributor

This refers to the pytorch version currently being developed.
We should probably move the training functions into a train() method of each respective model class, for clarity.

@niekdejonge
Copy link
Collaborator

@florian-huber I am implementing this now.
We have a few settings that are now stored in SettingsMS2Deepscore (e.g. settings.evaluator_num_filters), but others have to be provided separately and are therefore not stored when saving the model (like mini_batch_size). I understand the separation, the first ones are necessary to run the model, while the others are only relevant during training. But I would prefer to store all training settings when saving a model, to make it easy for us (and other developers) to check which settings were used during training.
Shall I add these settings to init as well, to ensure that these are saved as well?

@niekdejonge
Copy link
Collaborator

And if we want to add them, shall I add them all to SettingsMS2Deepscore or shall I make a new Class EmbeddingsEvaluationModelSettings, or just add them as separate parameters in init of EmbeddingsEvaluator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants