Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #1746

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #1746

wants to merge 2 commits into from

Conversation

bodiakof
Copy link

No description provided.

L1nk3rrr
L1nk3rrr suggested changes Nov 25, 2024
View reviewed changes
Copy link

@L1nk3rrr L1nk3rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
From the code and logical side, all is good, but from formatting, I found 2 minor points to fix in this theme.

We don't need to newline after the name of the function(all your 3 functions have it)
Don't forget about newline at the end of a file.

L1nk3rrr
L1nk3rrr approved these changes Nov 26, 2024
View reviewed changes
Copy link

@L1nk3rrr L1nk3rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forget about comment with a blank line at the end of a file, for now I approve it, but next time will be returned to you, anyway you did task and improve main style point that commented previously

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L1nk3rrr L1nk3rrr L1nk3rrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bodiakof @L1nk3rrr