Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #1828

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #1828

wants to merge 1 commit into from

Conversation

bogdAAAn1
Copy link

No description provided.

KseniiaLog
KseniiaLog approved these changes Nov 26, 2024
View reviewed changes
Copy link

@KseniiaLog KseniiaLog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use different names for variables to avoid repeating the "error" in functions. It's not critical, but maybe then there will be no confusion. I'm accepting the assignment, just writing a comment for the future.

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Nov 26, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🎉 Your code in app/main.py meets all the task requirements and constraints. The functions are well-structured, adhere to the style guide, and effectively avoid code duplication. Keep up the excellent work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KseniiaLog KseniiaLog KseniiaLog approved these changes

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdAAAn1 @mateacademy-ai-mentor @KseniiaLog