-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
did the task Linter formatter.created three correct functions #1835
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the required functions! 🎉 The code is well-structured and meets all the task requirements. While the redundant pass
statements after return statements are unnecessary, they don't impact the functionality. Consider removing them for cleaner code in the future. Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
"message": error["text"], | ||
"name": error["code"], | ||
"source": "flake8" | ||
} | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pass
statement here is redundant because the function already returns a value. You can safely remove this line.
"errors": [format_linter_error(error) for error in errors], | ||
"path": file_path, | ||
"status": "failed" if errors else "passed" | ||
} | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pass
statement here is redundant because the function already returns a value. You can safely remove this line.
return [ | ||
format_single_linter_file(file_path, errors) | ||
for file_path, errors in linter_report.items() | ||
] | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pass
statement here is redundant because the function already returns a value. You can safely remove this line.
No description provided.