Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NavigationRailView] update comment (not BottomNavigationView but NavigationRailView) #4492

Open
manabu-nakamura opened this issue Dec 20, 2024 · 0 comments · May be fixed by #4493
Open

[NavigationRailView] update comment (not BottomNavigationView but NavigationRailView) #4492

manabu-nakamura opened this issue Dec 20, 2024 · 0 comments · May be fixed by #4493
Assignees
@imhappi
Labels
bug Widget: NavigationRail

Comments

@manabu-nakamura
Copy link
Contributor

Description: https://github.com/material-components/material-components-android/blob/master/lib/java/com/google/android/material/navigationrail/NavigationRailView.java#L719-L725:

  @SuppressLint("ClickableViewAccessibility")
  @Override
  public boolean onTouchEvent(@NonNull MotionEvent event) {
    super.onTouchEvent(event);
    // Consume all events to avoid views under the BottomNavigationView from receiving touch events.
    return true;
  }

Expected behavior:

  @SuppressLint("ClickableViewAccessibility")
  @Override
  public boolean onTouchEvent(@NonNull MotionEvent event) {
    super.onTouchEvent(event);
    // Consume all events to avoid views under the NavigationRailView from receiving touch events.
    return true;
  }

Material Library version: 1.13.0-alpha09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imhappi imhappi

Labels
bug Widget: NavigationRail
Projects
None yet
Milestone
No milestone
3 participants
@imhappi @paulfthomas @manabu-nakamura