Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre_release_branches default to catchall #139

Open
dctelus opened this issue Jul 27, 2022 · 0 comments
Open

pre_release_branches default to catchall #139

dctelus opened this issue Jul 27, 2022 · 0 comments

Comments

@dctelus
Copy link

dctelus commented Jul 27, 2022

The option pre_release_branches defaults to ``, but you are using .match which always returns true when passed an empty string.

branch = "anything";
Boolean(branch.match('')) # always true

https://github.com/mathieudutour/github-tag-action/blob/v6.0/src/action.ts#L58

We use this behavior but it is not intuitive (maybe documentation should be updated to say that all branches are prerelease).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dctelus