-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerelease does not Respect Default_Bump #145
Comments
lazyBisa
pushed a commit
to lazyBisa/github-tag-action
that referenced
this issue
Apr 21, 2023
lazyBisa
pushed a commit
to lazyBisa/github-tag-action
that referenced
this issue
Apr 21, 2023
…efaultPreReleaseBump only when updating a prerelease version **BREAKING CHANGE:** this change changes the behaviour of drafting prereleases
lazyBisa
pushed a commit
to lazyBisa/github-tag-action
that referenced
this issue
Apr 21, 2023
lazyBisa
pushed a commit
to lazyBisa/github-tag-action
that referenced
this issue
Apr 21, 2023
lazyBisa
pushed a commit
to lazyBisa/github-tag-action
that referenced
this issue
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When having
default_bump=minor
I would expect a prerelease to do a minor update when creating the prerelease version. Currently it always does a patch update.E.g.
latest release is
1.2.3
, I would expect an execution of the action on a branch basing from that version, with parametersdefault_bump=minor
anddefault_prerelease_bump=prerelease
to generate the version1.3.0-beta.0
, since 1.3.0 is the version the final release will (most likely) be.Instead, it currently generates the version
1.2.4-beta.0
, which is a patch increase.Another run on top should then do the correct prerelease update to create version
1.3.0-beta.1
I think adjustments need to address the code starting at
github-tag-action/src/action.ts
Line 155 in e923a61
You could argue that this is a bug/feature of semver itself, but it really is relating to correctly interpreting default actions which is responsibility of this module, not semver.
The text was updated successfully, but these errors were encountered: