Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svd.Determinant documentation error #1105

Open
apacker1 opened this issue Jan 3, 2025 · 1 comment · May be fixed by #1106
Open

Svd.Determinant documentation error #1105

apacker1 opened this issue Jan 3, 2025 · 1 comment · May be fixed by #1106

Comments

@apacker1
Copy link

apacker1 commented Jan 3, 2025

Hello,

This is kind of a trivial thing, but it tripped me up. The Intellisense for Svd.Determinant says "Gets the determinant of the square matrix for which the SVD was computed." But it actually returns the absolute value of the determinant. There are other "Determinant" properties, like Evd.Determinant and QR.Determinant, which also actually return the absolute value of the determinant, but the Intellisense for them makes that clear.

If you agree that the Intellisense for Svd.Determinant should say "Gets the absolute value of the determinant of the square matrix for which the SVD was computed.", I am happy to submit a PR making that change.

Thanks!

Asa

@apacker1 apacker1 linked a pull request Jan 3, 2025 that will close this issue
@apacker1
Copy link
Author

apacker1 commented Jan 3, 2025

Went ahead and submitted a PR since it was easy to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant