Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singleTabMode="fullwidth" does not update correctly with drag-n-drop #547

Open
vincent-lecrubier-skydio opened this issue Mar 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@vincent-lecrubier-skydio
Copy link

vincent-lecrubier-skydio commented Mar 11, 2024

Problem
In singleTabMode="fullwidth" , the "fullWidth-ness" of individual tab groups is initially correct, but then is not maintained correctly during the lifecycle:

  • It updates correctly when a tab is removed by closing it (If one tab is remaining it becomes full width) 🟢
  • Does not update correctly when a tab is removed by dragging it somewhere else (If one tab is remaining it remains non-full width) 🔴
  • Does not update correctly when a tab is added by dragging from somewhere else (If there was only one tab is the group such that it was full-width, then after another is added, you now have 2 tabs that are sharing the full width) 🔴

To Reproduce
I'm out of free codesandboxes, but it's super simple to reproduce:

Steps to reproduce the behavior:

  1. Use default dockview demo
  2. Add singleTabMode="fullwidth" to <DockviewReact/>
  3. Move tabs around by drag n drop

Expected behavior
The "fullWidth-ness" of individual tab groups remains correct

Screenshots

Screen.Recording.2024-03-11.at.12.06.38.PM.mov
@mathuo mathuo added the bug Something isn't working label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants