Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PT-E550W always cuts the label #44

Open
Bart97 opened this issue Aug 30, 2024 · 9 comments · May be fixed by matmair/brother_ql-inventree#68
Open

PT-E550W always cuts the label #44

Bart97 opened this issue Aug 30, 2024 · 9 comments · May be fixed by matmair/brother_ql-inventree#68

Comments

@Bart97
Copy link

Bart97 commented Aug 30, 2024

Hello. I've noticed that it's when using this plugin with the E550W the label is always cut at the end, it doesn't matter if I disable the option in the settings. I'd like to have the pre-cut done between labels, but feed&cut manually when I'm done printing all the labels.

@matmair
Copy link
Member

matmair commented Aug 30, 2024

Have you selected the right printer model? The protocol is a bit different between the models.

@Bart97
Copy link
Author

Bart97 commented Aug 30, 2024

Yes, seems that the problem lies in the brother_ql library. This model requires qlr.no_chain_printing = False to disable cutting at the end of print, however it is never set in conversion.py. I can prepare a PR tomorrow, but I'm not sure what's the intended behavior of that single UI option, as there's half-cut and end cut that can be toggled separately. Personally I need to disable end cut only, so I can print multiple labels without wasting tape.

@matmair
Copy link
Member

matmair commented Aug 31, 2024

we use brother_ql-inventree, a downstream fork I maintain

@Bart97
Copy link
Author

Bart97 commented Aug 31, 2024

we use brother_ql-inventree, a downstream fork I maintain

Got it, I'm testing a fix for this right now

@Bart97
Copy link
Author

Bart97 commented Aug 31, 2024

I've submitted a pull request that will resolve this issue matmair/brother_ql-inventree#68

@Bart97
Copy link
Author

Bart97 commented Sep 8, 2024

Hi, @matmair what's the status on this? What would be the proper process to get the fix merged into your fork?

@Bart97
Copy link
Author

Bart97 commented Oct 16, 2024

Hello @matmair any updates on merging the fix for this issue? I'd love to see a fix in the official repository, as right now I have to manually patch the library.

@matmair
Copy link
Member

matmair commented Oct 17, 2024

@Bart97 I am on the road an limited with my testing/hardware setups for a few more days, will review after that.

@Bart97
Copy link
Author

Bart97 commented Dec 13, 2024

Hi @matmair, sorry for bothering you again, any chance for merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants