Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot types #7489

Open
Simbiat opened this issue Oct 21, 2023 · 5 comments
Open

Bot types #7489

Simbiat opened this issue Oct 21, 2023 · 5 comments

Comments

@Simbiat
Copy link
Contributor

Simbiat commented Oct 21, 2023

Variable for bots $categories has some ambiguous types:

  • Feed Fetcher, Feed Parser, Feed Reader - what's the difference, really?
  • Read-it-later Service is used only for 2 items both for 1 thing: https://getpocket.com/pocketparser_ua. At the same time description on this page clearly says crawling, so should this not be Crawler?
  • Search tools is used only for 1 item: http://www.shopwiki.com/w/Help:Bot. Again, description clearly states, that this is a crawler, so should this not be Crawler?
  • How does Security search bot differ from Security Checker?
  • How does Service bot differ from Service Agent?
  • And probably the biggest of it all: what's the difference of Search bot from Crawler? I mean, crawling is done by search bots, so this seems to be the same thing.

I am fine with creating PR to harmonize these things a bit, but I think this warrants a proper discussion first.

@liviuconcioiu
Copy link
Collaborator

#5727

@Simbiat
Copy link
Contributor Author

Simbiat commented Oct 22, 2023

Hm, that one did not cover the questions above, in the end, although it did mention multiple feed bots, and it resulted in code for validating categories. I am, essentially, talking about cleaning up the types.

@sgiehl
Copy link
Member

sgiehl commented Oct 30, 2023

I guess we don't have a "clean" definition of categories to use. Feel free to create a PR to clean them up a bit.

@Simbiat
Copy link
Contributor Author

Simbiat commented Oct 30, 2023

I can add this to #7490. Or would a separate PR be better?

@sgiehl
Copy link
Member

sgiehl commented Oct 30, 2023

@Simbiat It's better to have a separate PR, as that makes reviewing easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants